Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068433003: Enable cros_interface unittests for all cros configs. (Closed)

Created:
4 years, 6 months ago by achuithb
Modified:
4 years, 5 months ago
Reviewers:
jdufault
CC:
catapult-reviews_chromium.org, telemetry-reviews_chromium.org
Base URL:
https://github.com/catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Enable cros_interface unittests for all cros configs. BUG=chromium:619767 TEST=These are the tests. Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f47272d62febb5f66b2f8d9a8d6ddc324e498ac1

Patch Set 1 : . #

Total comments: 2

Patch Set 2 : jdufault fix #

Patch Set 3 : rebase #

Patch Set 4 : testEscapeCmdArguments #

Patch Set 5 : Disable testTakeScreenshotWithPrefix #

Patch Set 6 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -42 lines) Patch
M telemetry/telemetry/core/cros_interface.py View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M telemetry/telemetry/core/cros_interface_unittest.py View 1 2 3 4 5 9 chunks +22 lines, -41 lines 0 comments Download

Messages

Total messages: 25 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068433003/20001
4 years, 6 months ago (2016-06-14 00:30:23 UTC) #3
achuithb
Jake, please take a look.
4 years, 6 months ago (2016-06-14 00:30:36 UTC) #5
jdufault
lgtm https://codereview.chromium.org/2068433003/diff/20001/telemetry/telemetry/core/cros_interface_unittest.py File telemetry/telemetry/core/cros_interface_unittest.py (right): https://codereview.chromium.org/2068433003/diff/20001/telemetry/telemetry/core/cros_interface_unittest.py#newcode30 telemetry/telemetry/core/cros_interface_unittest.py:30: @decorators.Enabled('cros-chrome') 'chromeos'?
4 years, 6 months ago (2016-06-14 01:06:41 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-14 01:37:47 UTC) #8
achuithb
thanks https://codereview.chromium.org/2068433003/diff/20001/telemetry/telemetry/core/cros_interface_unittest.py File telemetry/telemetry/core/cros_interface_unittest.py (right): https://codereview.chromium.org/2068433003/diff/20001/telemetry/telemetry/core/cros_interface_unittest.py#newcode30 telemetry/telemetry/core/cros_interface_unittest.py:30: @decorators.Enabled('cros-chrome') On 2016/06/14 01:06:41, jdufault wrote: > 'chromeos'? ...
4 years, 6 months ago (2016-06-14 02:53:42 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068433003/80001
4 years, 6 months ago (2016-06-14 02:54:01 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Windows Tryserver on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Windows%20Tryserver/builds/3375)
4 years, 6 months ago (2016-06-14 03:40:27 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068433003/100001
4 years, 6 months ago (2016-06-14 19:33:38 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2068433003/160001
4 years, 5 months ago (2016-06-27 12:43:09 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-06-27 13:46:15 UTC) #25
Message was sent while issue was closed. 
Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698