Issue 20684002: Inline platform-tls*.h files into platform.h.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 20684002: Inline platform-tls*.h files into platform.h. (Closed)

Created:
7 years, 5 months ago by Benedikt Meurer

Modified:
7 years, 5 months ago

Reviewers:
Sven Panne

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Created: 7 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+55 lines, -179 lines)			Patch
M	src/platform.h	View	4 chunks	+55 lines, -2 lines	0 comments	Download
D	src/platform-tls.h	View	1 chunk	+0 lines, -50 lines	0 comments	Download
D	src/platform-tls-mac.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
D	src/platform-tls-win32.h	View	1 chunk	+0 lines, -62 lines	0 comments	Download
M	tools/gyp/v8.gyp	View	1 chunk	+0 lines, -3 lines	0 comments	Download

Total messages: 3 (0 generated)

Sven Panne

LGTM, although all the #ifdefs regarding V8_NO_FAST_TLS and V8_FAST_TLS_SUPPORTED make my brain hurt. :-P But ...

7 years, 5 months ago (2013-07-26 08:58:23 UTC) #2

Benedikt Meurer

7 years, 5 months ago (2013-07-26 09:00:13 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r15892 (presubmit successful).