Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(977)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java

Issue 2068393002: Flag for Offline Page Sharing (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Resolve merge conflict Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
index 5da36d6f7d45c9f3d938172b5db94da3e25a1922..ef45409ef93d84662192ba759f170441bc67c600 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridgeTest.java
@@ -138,7 +138,6 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
offlinePage.getOfflineUrl().endsWith(".mhtml"));
assertTrue("Offline page item offline file doesn't have the right name.",
offlinePage.getOfflineUrl().contains("About"));
-
assertNull("Offline page is not supposed to exist",
getPageByClientId(new ClientId(OfflinePageBridge.BOOKMARK_NAMESPACE, "-42")));
}
@@ -167,6 +166,18 @@ public class OfflinePageBridgeTest extends ChromeActivityTestCaseBase<ChromeActi
});
}
+ @CommandLineFlags.Add("disable-features=OfflinePagesSharing")
+ @SmallTest
+ public void testPageSharingSwitch() throws Exception {
+ ThreadUtils.runOnUiThreadBlocking(new Runnable() {
+ @Override
+ public void run() {
+ assertFalse("If offline page sharing is off, we should see the feature disabled",
+ OfflinePageBridge.isPageSharingEnabled());
+ }
+ });
+ }
+
@SmallTest
public void testCheckPagesExistOffline() throws Exception {
// If we save a page, then it should exist in the result.

Powered by Google App Engine
This is Rietveld 408576698