Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: test/io.dart

Issue 2068363002: pkg/test: Resolve a number of analyzer warnings (Closed) Base URL: https://github.com/dart-lang/test.git@master
Patch Set: more nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/utils.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/io.dart
diff --git a/test/io.dart b/test/io.dart
index 00bb3e0c12bf801fd3ab5a5e59ad6babd7bbf560..b89e40cb90916bcf5f8b41d6fe663dc5262114ae 100644
--- a/test/io.dart
+++ b/test/io.dart
@@ -7,7 +7,6 @@
library test.test.io;
import 'dart:async';
-import 'dart:convert';
import 'dart:io';
import 'package:path/path.dart' as p;
@@ -16,7 +15,6 @@ import 'package:scheduled_test/scheduled_process.dart';
import 'package:scheduled_test/scheduled_stream.dart';
import 'package:scheduled_test/scheduled_test.dart';
import 'package:test/src/util/io.dart';
-import 'package:yaml/yaml.dart';
/// The path to the root directory of the `test` package.
final String packageDir = p.dirname(p.dirname(libraryPath(#test.test.io)));
@@ -104,7 +102,7 @@ StreamMatcher containsInOrder(Iterable<String> strings) =>
///
/// If [forwardStdio] is true, the standard output and error from the process
/// will be printed as part of the parent test. This is used for debugging.
-ScheduledProcess runTest(List args, {String reporter,
+ScheduledProcess runTest(List<String> args, {String reporter,
int concurrency, Map<String, String> environment,
bool forwardStdio: false}) {
concurrency ??= 1;
@@ -133,7 +131,7 @@ ScheduledProcess runTest(List args, {String reporter,
}
/// Runs Dart.
-ScheduledProcess runDart(List args, {Map<String, String> environment,
+ScheduledProcess runDart(List<String> args, {Map<String, String> environment,
String description}) {
var allArgs = Platform.executableArguments.map((arg) {
// The package root might be relative, so we need to make it absolute if
@@ -163,7 +161,7 @@ ScheduledProcess runPub(List args, {Map<String, String> environment}) {
///
/// This returns assigns [_pubServePort] to a future that will complete to the
/// port of the "pub serve" instance.
-ScheduledProcess runPubServe({List args, String workingDirectory,
+ScheduledProcess runPubServe({List<String> args, String workingDirectory,
Map<String, String> environment}) {
_pubServePortCompleter = new Completer();
currentSchedule.onComplete.schedule(() => _pubServePortCompleter = null);
« no previous file with comments | « lib/src/utils.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698