Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: lib/src/runner/loader.dart

Issue 2068363002: pkg/test: Resolve a number of analyzer warnings (Closed) Base URL: https://github.com/dart-lang/test.git@master
Patch Set: more nits Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/src/runner/browser/content_shell.dart ('k') | lib/src/util/io.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/src/runner/loader.dart
diff --git a/lib/src/runner/loader.dart b/lib/src/runner/loader.dart
index 67c2835f282aaeff308c15ca7f06c96cc87415bb..9f74b952355158f78cb0c17b717e3c4498fae7d3 100644
--- a/lib/src/runner/loader.dart
+++ b/lib/src/runner/loader.dart
@@ -30,9 +30,6 @@ class Loader {
/// The test runner configuration.
final Configuration _config;
- /// The root directory that will be served for browser tests.
- final String _root;
-
/// All suites that have been created by the loader.
final _suites = new Set<RunnerSuite>();
@@ -48,8 +45,7 @@ class Loader {
///
/// [root] is the root directory that will be served for browser tests. It
/// defaults to the working directory.
- Loader(this._config, {String root})
- : _root = root == null ? p.current : root {
+ Loader(this._config, {String root}) {
registerPlatformPlugin([TestPlatform.vm], () => new VMPlatform(_config));
registerPlatformPlugin([
TestPlatform.dartium,
« no previous file with comments | « lib/src/runner/browser/content_shell.dart ('k') | lib/src/util/io.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698