lib/src/runner/browser/content_shell.dart - Issue 2068363002: pkg/test: Resolve a number of analyzer warnings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/src/runner/browser/content_shell.dart

Issue 2068363002: pkg/test: Resolve a number of analyzer warnings (Closed) Base URL: https://github.com/dart-lang/test.git@master

Patch Set: nits Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/src/runner/browser/content_shell.dart

diff --git a/lib/src/runner/browser/content_shell.dart b/lib/src/runner/browser/content_shell.dart

index 35908dcf8532779d596f5741a3d4d6920227f8fe..c3002404b523018bbb59a86027f573efe68f78bb 100644

--- a/lib/src/runner/browser/content_shell.dart

+++ b/lib/src/runner/browser/content_shell.dart

@@ -105,7 +105,7 @@ class ContentShell extends Browser {

var client = new HttpClient();

var request = await client.getUrl(base.resolve("/json/list"));

var response = await request.close();

- var json = await JSON.fuse(UTF8).decoder.bind(response).single;

+ var json = await JSON.fuse(UTF8).decoder.bind(response).single as List;

return base.resolve(json.first["devtoolsFrontendUrl"]);

} catch (_) {

// If we fail to talk to the remote debugger protocol, give up and return