Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 2068343003: Revert "Send input event IPCs directly from the UI thread" (Closed)

Created:
4 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, chromium-reviews, creis+watch_chromium.org, darin (slow to review), darin-cc_chromium.org, jam, nasko+codewatch_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert "Send input event IPCs directly from the UI thread" This reverts commit 868f89e764ab0e807adb237f0cbaf79ca5f49257. See https://codereview.chromium.org/1991323002 for the original CL. Per offline discussions: there was no clear benefit from using SendNow for input events, and having the extra interface adds unnecessary complexity given that nobody is going to work on porting Send call sites. BUG=612944 R=jam@chromium.org Committed: https://crrev.com/f14a8ae8f52b814820b29752996c5cee903a8d4d Cr-Commit-Position: refs/heads/master@{#400227}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -222 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 5 chunks +2 lines, -14 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 1 9 chunks +40 lines, -69 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_impl.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/public/browser/render_process_host.h View 1 chunk +0 lines, -8 lines 0 comments Download
M content/public/test/mock_render_process_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +1 line, -9 lines 0 comments Download
M ipc/ipc_channel_proxy.h View 4 chunks +4 lines, -19 lines 0 comments Download
M ipc/ipc_channel_proxy.cc View 4 chunks +35 lines, -40 lines 0 comments Download
M ipc/ipc_sync_channel.h View 1 chunk +0 lines, -2 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +0 lines, -32 lines 0 comments Download
M ipc/ipc_sync_message_filter.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ipc/ipc_sync_message_filter.cc View 2 chunks +4 lines, -14 lines 0 comments Download
M ipc/mojo/ipc_channel_mojo.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Ken Rockot(use gerrit already)
PTAL. This was a straightforward revert so I don't think there's any risk of badness.
4 years, 6 months ago (2016-06-15 22:10:12 UTC) #1
jam
lgtm
4 years, 6 months ago (2016-06-16 16:17:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068343003/1
4 years, 6 months ago (2016-06-16 16:21:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/245402)
4 years, 6 months ago (2016-06-16 16:28:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068343003/20001
4 years, 6 months ago (2016-06-16 18:23:44 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 19:28:59 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 19:31:10 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/f14a8ae8f52b814820b29752996c5cee903a8d4d
Cr-Commit-Position: refs/heads/master@{#400227}

Powered by Google App Engine
This is Rietveld 408576698