Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2068313002: [Extensions] Omit the "Inspect popup" menu item for synthesized actions (Closed)

Created:
4 years, 6 months ago by Devlin
Modified:
4 years, 6 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Omit the "Inspect popup" menu item for synthesized actions Extensions that don't specify a page or browser action with have a page action synthesized. However, these actions will never have an associated popup, so it doesn't make sense to add the menu item. BUG=620417 Committed: https://crrev.com/7535915c038056073769a5c742cc02781b7bec49 Cr-Commit-Position: refs/heads/master@{#400037}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -3 lines) Patch
M chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_context_menu_model_unittest.cc View 2 chunks +42 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
Devlin
Istiaque, mind taking a look?
4 years, 6 months ago (2016-06-15 22:07:19 UTC) #2
lazyboy
lgtm.
4 years, 6 months ago (2016-06-15 22:53:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068313002/1
4 years, 6 months ago (2016-06-15 22:57:17 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 23:04:54 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 23:05:11 UTC) #11
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 23:08:13 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7535915c038056073769a5c742cc02781b7bec49
Cr-Commit-Position: refs/heads/master@{#400037}

Powered by Google App Engine
This is Rietveld 408576698