Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2068263002:
Test262 roll (Closed)
|
Created:
4 years, 6 months ago by Dan Ehrenberg Modified:
4 years, 6 months ago Reviewers:
adamk CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
DescriptionTest262 roll
This roll does not include a test harness change; infrastructure issues
still need to be worked out.
Committed: https://crrev.com/d3a95b8a78eefabf884a60bc3d6aac5830b44eb3
Cr-Commit-Position: refs/heads/master@{#37225}
Patch Set 1 #Patch Set 2 : Some test failures #Patch Set 3 : more test failures #Patch Set 4 : more failures #Patch Set 5 : More test expectations #Patch Set 6 : Some more tests #Patch Set 7 : Some more tests #Patch Set 8 : More test failures marked #Patch Set 9 : More fixes #Patch Set 10 : Rebase #Patch Set 11 : Reorder and de-dup #Patch Set 12 : Rebase #
Total comments: 2
Patch Set 13 : Don't try to make error message prettier #Patch Set 14 : Roll back harness change #Patch Set 15 : Test262 roll #Messages
Total messages: 46 (22 generated)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/160001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel_ng/buil...) v8_linux_arm64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm64_rel_ng/build...) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_mips64el_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mips64el_compile_r...) v8_linux_mipsel_compile_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_mipsel_compile_rel...) v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17717)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/180001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17719)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/200001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng/builds/7691) v8_linux64_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_rel_ng_triggered...) v8_linux_arm_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng/builds/...) v8_linux_arm_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel_ng_trigger...) v8_linux_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng/builds/7650) v8_linux_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_rel_ng_triggered/b...)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/220001
littledan@chromium.org changed reviewers: + adamk@chromium.org
lgtm % python nit https://codereview.chromium.org/2068263002/diff/220001/test/test262/testcfg.py File test/test262/testcfg.py (right): https://codereview.chromium.org/2068263002/diff/220001/test/test262/testcfg.p... test/test262/testcfg.py:42: raise ImportError("Cannot load parseTestRecord; you may need to " Not sure this is worthwhile. If I patch in this change and don't sync, I get an error before we hit this.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
https://codereview.chromium.org/2068263002/diff/220001/test/test262/testcfg.py File test/test262/testcfg.py (right): https://codereview.chromium.org/2068263002/diff/220001/test/test262/testcfg.p... test/test262/testcfg.py:42: raise ImportError("Cannot load parseTestRecord; you may need to " On 2016/06/22 at 21:54:07, adamk wrote: > Not sure this is worthwhile. If I patch in this change and don't sync, I get an error before we hit this. Good point; removed this.
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_dbg_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng/builds/7740) v8_linux_dbg_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_dbg_ng_triggered/b...)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/240001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: v8_linux_nodcheck_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng/bu...) v8_linux_nodcheck_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_nodcheck_rel_ng_tr...)
The CQ bit was checked by littledan@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/260001
Description was changed from ========== Test262 roll This roll includes new test harness infrastructure, based on work from Mike Pennisi. TC-39 recently decided to remove the Python-based testing harness from the Test262 project [1]. The code has been duplicated in a standalone project; update V8's dependencies to fetch from that new location, a Chromium mirror of a GitHub project. [1] https://github.com/tc39/tc39-notes/blob/2b9722db9b90011d6083a5f1c8ff1559cbe01... BUG=v8:5078 ========== to ========== Test262 roll This roll does not include a test harness change; infrastructure issues still need to be worked out. ==========
The CQ bit was unchecked by littledan@chromium.org
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/2068263002/#ps260001 (title: "Roll back harness change")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/260001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_linux64_asan_rel_ng on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng/buil...) v8_linux64_asan_rel_ng_triggered on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel_ng_trig...)
The CQ bit was checked by littledan@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org Link to the patchset: https://codereview.chromium.org/2068263002/#ps280001 (title: "Test262 roll")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068263002/280001
Message was sent while issue was closed.
Committed patchset #15 (id:280001)
Message was sent while issue was closed.
Description was changed from ========== Test262 roll This roll does not include a test harness change; infrastructure issues still need to be worked out. ========== to ========== Test262 roll This roll does not include a test harness change; infrastructure issues still need to be worked out. Committed: https://crrev.com/d3a95b8a78eefabf884a60bc3d6aac5830b44eb3 Cr-Commit-Position: refs/heads/master@{#37225} ==========
Message was sent while issue was closed.
Patchset 15 (id:??) landed as https://crrev.com/d3a95b8a78eefabf884a60bc3d6aac5830b44eb3 Cr-Commit-Position: refs/heads/master@{#37225}
Message was sent while issue was closed.
A revert of this CL (patchset #15 id:280001) has been created in https://codereview.chromium.org/2094613004/ by littledan@chromium.org. The reason for reverting is: Broke msan and tsan; need to add an extra skip.
Message was sent while issue was closed.
On 2016/06/23 19:29:26, Dan Ehrenberg wrote: > A revert of this CL (patchset #15 id:280001) has been created in > https://codereview.chromium.org/2094613004/ by mailto:littledan@chromium.org. > > The reason for reverting is: Broke msan and tsan; need to add an extra skip.
Message was sent while issue was closed.
Regarding harness: If you add a new deps you need to: 1) Add the folder to .gitignore 2) Include the needed extra files in test/test262/test262.isolate - so that they are copied to the swarming bots. You can test locally what's copied by using the remap command of the isolate.py client. https://github.com/luci/luci-py cd luci-py/client ./isolate.py help remap You need to pass -i and -o. |
