Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2068203002:
Adding unit test for characteristic notification. (Closed)
|
Created:
4 years, 6 months ago by jlebel Modified:
4 years, 6 months ago Reviewers:
ortuno CC:
chromium-reviews, ortuno+watch_chromium.org, scheib+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@characteristicscan_servicescan_cleanup Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAdding unit test to observe notification when a characteristic is added and
removed
BUG=None
Committed: https://crrev.com/09d68138f934a472dedb9b321e2cef88e9279806
Cr-Commit-Position: refs/heads/master@{#400753}
Patch Set 1 #Patch Set 2 : Merge #Patch Set 3 : Moving the test in GetCharacteristic_CharacteristicRemoved #Patch Set 4 : Merge #Patch Set 5 : Merge #Patch Set 6 : Removing windows #Patch Set 7 : Renaming test to GattCharacteristics_ObserversCalls #Patch Set 8 : Merge top of tree #Messages
Total messages: 33 (16 generated)
Description was changed from ========== Adding unit test. BUG=None ========== to ========== Adding unit test to observe notification when a characteristic is added and removed BUG=None ==========
jlebel@chromium.org changed reviewers: + ortuno@chromium.org
Hello Giovanni, Can you review this patch for the test you asked me? Thanks,
The CQ bit was checked by jlebel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068203002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
BluetoothRemoteGattServiceTest, GetCharacteristic_CharacteristicRemoved seems to be very similar to this test. Move it here (instead of making a new test) and add checks for CharacteristicAdded.
The CQ bit was checked by jlebel@chromium.org to run a CQ dry run
Done.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068203002/40001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
The CQ bit was checked by jlebel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068203002/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)
The CQ bit was checked by jlebel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068203002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jlebel@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068203002/120001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by jlebel@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from ortuno@chromium.org Link to the patchset: https://codereview.chromium.org/2068203002/#ps140001 (title: "Merge top of tree")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068203002/140001
Message was sent while issue was closed.
Description was changed from ========== Adding unit test to observe notification when a characteristic is added and removed BUG=None ========== to ========== Adding unit test to observe notification when a characteristic is added and removed BUG=None ==========
Message was sent while issue was closed.
Committed patchset #8 (id:140001)
Message was sent while issue was closed.
Description was changed from ========== Adding unit test to observe notification when a characteristic is added and removed BUG=None ========== to ========== Adding unit test to observe notification when a characteristic is added and removed BUG=None Committed: https://crrev.com/09d68138f934a472dedb9b321e2cef88e9279806 Cr-Commit-Position: refs/heads/master@{#400753} ==========
Message was sent while issue was closed.
Patchset 8 (id:??) landed as https://crrev.com/09d68138f934a472dedb9b321e2cef88e9279806 Cr-Commit-Position: refs/heads/master@{#400753} |
