Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1716)

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json

Issue 2068183002: V8: Move gn-peek step behind mb step (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json b/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json
index 44db3776bb0351e72c9af9dedf17c1695000fc73..0a0045d70966effbc3c50a3c2179bc813d49d78d 100644
--- a/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json
+++ b/scripts/slave/recipes/v8.expected/full_client_v8_ports_V8_Linux___x87___nosnap___debug.json
@@ -130,45 +130,6 @@
"cmd": [
"python",
"-u",
- "[DEPOT_TOOLS]/gn.py",
- "--root=[SLAVE_BUILD]/v8",
- "gen",
- "[TMP_BASE]/v8_gn_tmp_1",
- "--args=is_debug=true target_cpu=\"x86\" use_goma=true goma_dir=\"[CACHE]/cipd/goma\""
- ],
- "name": "gn"
- },
- {
- "cmd": [
- "python",
- "-u",
- "[SLAVE_BUILD]/v8/tools/gyp_flag_compare.py",
- "[TMP_BASE]/v8_gn_tmp_1",
- "[SLAVE_BUILD]/v8/out/Debug",
- "all",
- "all"
- ],
- "name": "compare build flags (fyi)"
- },
- {
- "cmd": [
- "python",
- "-u",
- "\nimport shutil, sys\nshutil.rmtree(sys.argv[1])\n",
- "[TMP_BASE]/v8_gn_tmp_1"
- ],
- "name": "rmtree [TMP_BASE]/v8_gn_tmp_1",
- "~followup_annotations": [
- "@@@STEP_LOG_LINE@python.inline@@@@",
- "@@@STEP_LOG_LINE@python.inline@import shutil, sys@@@",
- "@@@STEP_LOG_LINE@python.inline@shutil.rmtree(sys.argv[1])@@@",
- "@@@STEP_LOG_END@python.inline@@@"
- ]
- },
- {
- "cmd": [
- "python",
- "-u",
"RECIPE_PACKAGE_REPO[build]/scripts/tools/runit.py",
"--show-path",
"python",

Powered by Google App Engine
This is Rietveld 408576698