Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: scripts/slave/recipe_modules/v8/api.py

Issue 2068183002: V8: Move gn-peek step behind mb step (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2013 The Chromium Authors. All rights reserved. 1 # Copyright 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import argparse 5 import argparse
6 import datetime 6 import datetime
7 import random 7 import random
8 import re 8 import re
9 import urllib 9 import urllib
10 10
(...skipping 382 matching lines...) Expand 10 before | Expand all | Expand 10 after
393 use_goma = (self.m.chromium.c.compile_py.compiler and 393 use_goma = (self.m.chromium.c.compile_py.compiler and
394 'goma' in self.m.chromium.c.compile_py.compiler) 394 'goma' in self.m.chromium.c.compile_py.compiler)
395 self.m.chromium.run_mb( 395 self.m.chromium.run_mb(
396 self.m.properties['mastername'], 396 self.m.properties['mastername'],
397 self.m.properties['buildername'], 397 self.m.properties['buildername'],
398 use_goma=use_goma, 398 use_goma=use_goma,
399 mb_config_path=self.m.path['checkout'].join( 399 mb_config_path=self.m.path['checkout'].join(
400 'infra', 'mb', 'mb_config.pyl'), 400 'infra', 'mb', 'mb_config.pyl'),
401 gyp_script=self.m.path.join('gypfiles', 'gyp_v8'), 401 gyp_script=self.m.path.join('gypfiles', 'gyp_v8'),
402 ) 402 )
403 self.peek_gn()
403 self.m.chromium.compile(**kwargs) 404 self.m.chromium.compile(**kwargs)
404 self.isolate_tests() 405 self.isolate_tests()
405 406
406 # TODO(machenbach): This should move to a dynamorio module as soon as one 407 # TODO(machenbach): This should move to a dynamorio module as soon as one
407 # exists. 408 # exists.
408 def dr_compile(self): 409 def dr_compile(self):
409 self.m.file.makedirs( 410 self.m.file.makedirs(
410 'Create Build Dir', 411 'Create Build Dir',
411 self.m.path['slave_build'].join('dynamorio', 'build')) 412 self.m.path['slave_build'].join('dynamorio', 'build'))
412 self.m.step( 413 self.m.step(
(...skipping 747 matching lines...) Expand 10 before | Expand all | Expand 10 after
1160 def report_culprits(self, culprit_range): 1161 def report_culprits(self, culprit_range):
1161 assert culprit_range 1162 assert culprit_range
1162 if len(culprit_range) > 1: 1163 if len(culprit_range) > 1:
1163 text = 'Suspecting multiple commits' 1164 text = 'Suspecting multiple commits'
1164 else: 1165 else:
1165 text = 'Suspecting %s' % culprit_range[0][:8] 1166 text = 'Suspecting %s' % culprit_range[0][:8]
1166 1167
1167 step_result = self.m.step(text, cmd=None) 1168 step_result = self.m.step(text, cmd=None)
1168 for culprit in culprit_range: 1169 for culprit in culprit_range:
1169 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit 1170 step_result.presentation.links[culprit[:8]] = COMMIT_TEMPLATE % culprit
OLDNEW
« no previous file with comments | « no previous file | scripts/slave/recipes/v8.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698