Align the Mac Omnibox items vertically again

Align the Mac Omnibox items vertically again

OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it larger. Resource bundle will do the opposite, which makes a large system normal font a non-system bold font. That gives a different baseline to making the non-system bold font larger. And while the omnibox locks the baseline in ApplyTextStyle(), OmniboxPopupCellData does not.

BUG=617144
Committed: https://crrev.com/8f451b79fd88739803ce327a315e3d84ea2c752c
Cr-Commit-Position: refs/heads/master@{#400144}

[joleksy, 2016-06-15 13:27:34]

Description was changed from

==========
Align the Mac Omnibox items vertically again

BUG=617144
==========

to

==========
Align the Mac Omnibox items vertically again

BUG=617144
==========

[joleksy, 2016-06-15 13:28:56]

joleksy@opera.com changed reviewers:
+ tapted@chromium.org

[joleksy, 2016-06-15 13:28:57]

@reviewer: does it look ok to you?

[tapted, 2016-06-16 00:48:08]

lgtm, but please say something about the fix in the CL description. It can just
be the entire comment almost verbatim. E.g.

"OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it
larger. Resource bundle will do the opposite.... etc."

[joleksy, 2016-06-16 12:59:59]

Description was changed from

==========
Align the Mac Omnibox items vertically again

BUG=617144
==========

to

==========
Align the Mac Omnibox items vertically again

OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it
larger. Resource bundle will do the opposite, which makes a large system normal
font a non-system bold font. That gives a different baseline to making the
non-system bold font larger. And while the omnibox locks the baseline in
ApplyTextStyle(), OmniboxPopupCellData does not.

BUG=617144
==========

[joleksy, 2016-06-16 13:00:12]

The CQ bit was checked by joleksy@opera.com

[commit-bot: I haz the power, 2016-06-16 13:00:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2068163002/1

[commit-bot: I haz the power, 2016-06-16 13:52:22]

Description was changed from

==========
Align the Mac Omnibox items vertically again

OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it
larger. Resource bundle will do the opposite, which makes a large system normal
font a non-system bold font. That gives a different baseline to making the
non-system bold font larger. And while the omnibox locks the baseline in
ApplyTextStyle(), OmniboxPopupCellData does not.

BUG=617144
==========

to

==========
Align the Mac Omnibox items vertically again

OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it
larger. Resource bundle will do the opposite, which makes a large system normal
font a non-system bold font. That gives a different baseline to making the
non-system bold font larger. And while the omnibox locks the baseline in
ApplyTextStyle(), OmniboxPopupCellData does not.

BUG=617144
==========

[commit-bot: I haz the power, 2016-06-16 13:52:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-16 13:52:29]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 13:53:28]

Description was changed from

==========
Align the Mac Omnibox items vertically again

OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it
larger. Resource bundle will do the opposite, which makes a large system normal
font a non-system bold font. That gives a different baseline to making the
non-system bold font larger. And while the omnibox locks the baseline in
ApplyTextStyle(), OmniboxPopupCellData does not.

BUG=617144
==========

to

==========
Align the Mac Omnibox items vertically again

OmniboxViewMac::GetBoldFieldFont() needs to request a bold font, then make it
larger. Resource bundle will do the opposite, which makes a large system normal
font a non-system bold font. That gives a different baseline to making the
non-system bold font larger. And while the omnibox locks the baseline in
ApplyTextStyle(), OmniboxPopupCellData does not.

BUG=617144

Committed: https://crrev.com/8f451b79fd88739803ce327a315e3d84ea2c752c
Cr-Commit-Position: refs/heads/master@{#400144}
==========

[commit-bot: I haz the power, 2016-06-16 13:53:29]

Patchset 1 (id:??) landed as
https://crrev.com/8f451b79fd88739803ce327a315e3d84ea2c752c
Cr-Commit-Position: refs/heads/master@{#400144}