Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(221)

Issue 2068143002: Revert of Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
Reviewers:
fmeawad, Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) (patchset #2 id:20001 of https://codereview.chromium.org/2063853002/ ) Reason for revert: [Sheriff] Speculative revert for http://crbug.com/620279 Original issue's description: > Reland: Add a trace-event for each runtime-stats timer (CL 2052523002) > > The trace-events will have a high overhead when turned on, but they are in a disabled-by-default category. > > As long as the off overhead is negligible, this CL allows us to understand the behavior of V8 rather than its performance at the moment. > > The original CL was failing the TSAN builder, the variable in question was intended to be accessed quickly with no guarantee. > Switched to using an Atomic variable with no barrier read/write. > > BUG=v8:5089 > > patch from issue 2052523002 at patchset 100001 (http://crrev.com/2052523002#ps100001) > > Committed: https://crrev.com/fd7080cbefc21f2f890b5db00d4eadf163e2cbbf > Cr-Commit-Position: refs/heads/master@{#36973} TBR=cbruni@chromium.org,fmeawad@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5089 Committed: https://crrev.com/6d96d19f1f8f4873b581d3635149fd4e42eb2ffa Cr-Commit-Position: refs/heads/master@{#36997}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -62 lines) Patch
M src/api.cc View 10 chunks +0 lines, -11 lines 0 comments Download
M src/api-arguments.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M src/api-arguments-inl.h View 5 chunks +0 lines, -5 lines 0 comments Download
M src/counters.h View 2 chunks +0 lines, -2 lines 0 comments Download
M src/execution.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/lookup.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.cc View 3 chunks +0 lines, -7 lines 0 comments Download
M src/tracing/trace-event.h View 2 chunks +0 lines, -28 lines 0 comments Download
M src/tracing/trace-event.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Achenbach
Created Revert of Reland: Add a trace-event for each runtime-stats timer (CL 2052523002)
4 years, 6 months ago (2016-06-15 11:43:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068143002/1
4 years, 6 months ago (2016-06-15 11:43:49 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-15 11:44:03 UTC) #4
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 11:45:46 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6d96d19f1f8f4873b581d3635149fd4e42eb2ffa
Cr-Commit-Position: refs/heads/master@{#36997}

Powered by Google App Engine
This is Rietveld 408576698