Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8977)

Unified Diff: chrome/renderer/extensions/cast_streaming_native_handler.cc

Issue 2068133005: Refactoring: Use enum for RtpPayloadType. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Revert to Patch 2. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/cast_messages.h ('k') | chrome/renderer/media/cast_rtp_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/extensions/cast_streaming_native_handler.cc
diff --git a/chrome/renderer/extensions/cast_streaming_native_handler.cc b/chrome/renderer/extensions/cast_streaming_native_handler.cc
index c03f63fc5607ae012e854405569efef0f9a5d0d0..4b20c600c93c2dcc681dec64d32838d28405cb73 100644
--- a/chrome/renderer/extensions/cast_streaming_native_handler.cc
+++ b/chrome/renderer/extensions/cast_streaming_native_handler.cc
@@ -96,7 +96,6 @@ bool HexDecode(const std::string& input, std::string* output) {
bool ToCastRtpPayloadParamsOrThrow(v8::Isolate* isolate,
const RtpPayloadParams& ext_params,
CastRtpPayloadParams* cast_params) {
- cast_params->payload_type = ext_params.payload_type;
cast_params->max_latency_ms = ext_params.max_latency;
cast_params->min_latency_ms =
ext_params.min_latency ? *ext_params.min_latency : ext_params.max_latency;
@@ -104,6 +103,17 @@ bool ToCastRtpPayloadParamsOrThrow(v8::Isolate* isolate,
? *ext_params.animated_latency
: ext_params.max_latency;
cast_params->codec_name = ext_params.codec_name;
+ if (cast_params->codec_name == "OPUS") {
+ cast_params->payload_type = media::cast::RtpPayloadType::AUDIO_OPUS;
+ } else if (cast_params->codec_name == "PCM16") {
+ cast_params->payload_type = media::cast::RtpPayloadType::AUDIO_PCM16;
+ } else if (cast_params->codec_name == "AAC") {
+ cast_params->payload_type = media::cast::RtpPayloadType::AUDIO_AAC;
+ } else if (cast_params->codec_name == "VP8") {
+ cast_params->payload_type = media::cast::RtpPayloadType::VIDEO_VP8;
+ } else if (cast_params->codec_name == "H264") {
+ cast_params->payload_type = media::cast::RtpPayloadType::VIDEO_H264;
+ }
cast_params->ssrc = ext_params.ssrc;
cast_params->feedback_ssrc = ext_params.feedback_ssrc;
cast_params->clock_rate = ext_params.clock_rate ? *ext_params.clock_rate : 0;
@@ -137,7 +147,7 @@ bool ToCastRtpPayloadParamsOrThrow(v8::Isolate* isolate,
void FromCastRtpPayloadParams(const CastRtpPayloadParams& cast_params,
RtpPayloadParams* ext_params) {
- ext_params->payload_type = cast_params.payload_type;
+ ext_params->payload_type = static_cast<int>(cast_params.payload_type);
ext_params->max_latency = cast_params.max_latency_ms;
ext_params->min_latency.reset(new int(cast_params.min_latency_ms));
ext_params->animated_latency.reset(new int(cast_params.animated_latency_ms));
@@ -676,23 +686,23 @@ bool CastStreamingNativeHandler::FrameReceiverConfigFromArg(
if (params->codec_name == "OPUS") {
config->codec = media::cast::CODEC_AUDIO_OPUS;
config->rtp_timebase = 48000;
- config->rtp_payload_type = media::cast::kDefaultRtpAudioPayloadType;
+ config->rtp_payload_type = media::cast::RtpPayloadType::AUDIO_OPUS;
} else if (params->codec_name == "PCM16") {
config->codec = media::cast::CODEC_AUDIO_PCM16;
config->rtp_timebase = 48000;
- config->rtp_payload_type = media::cast::kDefaultRtpAudioPayloadType;
+ config->rtp_payload_type = media::cast::RtpPayloadType::AUDIO_PCM16;
} else if (params->codec_name == "AAC") {
config->codec = media::cast::CODEC_AUDIO_AAC;
config->rtp_timebase = 48000;
- config->rtp_payload_type = media::cast::kDefaultRtpAudioPayloadType;
+ config->rtp_payload_type = media::cast::RtpPayloadType::AUDIO_AAC;
} else if (params->codec_name == "VP8") {
config->codec = media::cast::CODEC_VIDEO_VP8;
config->rtp_timebase = 90000;
- config->rtp_payload_type = media::cast::kDefaultRtpVideoPayloadType;
+ config->rtp_payload_type = media::cast::RtpPayloadType::VIDEO_VP8;
} else if (params->codec_name == "H264") {
config->codec = media::cast::CODEC_VIDEO_H264;
config->rtp_timebase = 90000;
- config->rtp_payload_type = media::cast::kDefaultRtpVideoPayloadType;
+ config->rtp_payload_type = media::cast::RtpPayloadType::VIDEO_H264;
}
if (params->rtp_timebase) {
config->rtp_timebase = *params->rtp_timebase;
« no previous file with comments | « chrome/common/cast_messages.h ('k') | chrome/renderer/media/cast_rtp_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698