Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(898)

Unified Diff: tools/gn/target_generator.cc

Issue 206813002: Remove GN GYP generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/target_generator.h ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target_generator.cc
diff --git a/tools/gn/target_generator.cc b/tools/gn/target_generator.cc
index 2fb178ab3e9a2f9a56119cd8cc9a70e3855cefc9..a763a31e305ea8fda1c5ceeccf2ffb27f4694d63 100644
--- a/tools/gn/target_generator.cc
+++ b/tools/gn/target_generator.cc
@@ -39,7 +39,6 @@ void TargetGenerator::Run() {
FillDependentConfigs();
FillData();
FillDependencies();
- FillGypFile();
// Do type-specific generation.
DoRun();
@@ -173,17 +172,6 @@ void TargetGenerator::FillDependencies() {
FillHardDep();
}
-void TargetGenerator::FillGypFile() {
- const Value* gyp_file_value = scope_->GetValue(variables::kGypFile, true);
- if (!gyp_file_value)
- return;
- if (!gyp_file_value->VerifyTypeIs(Value::STRING, err_))
- return;
-
- target_->set_gyp_file(scope_->GetSourceDir().ResolveRelativeFile(
- gyp_file_value->string_value()));
-}
-
void TargetGenerator::FillHardDep() {
const Value* hard_dep_value = scope_->GetValue(variables::kHardDep, true);
if (!hard_dep_value)
@@ -193,15 +181,6 @@ void TargetGenerator::FillHardDep() {
target_->set_hard_dep(hard_dep_value->boolean_value());
}
-void TargetGenerator::FillExternal() {
- const Value* value = scope_->GetValue(variables::kExternal, true);
- if (!value)
- return;
- if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
- return;
- target_->set_external(value->boolean_value());
-}
-
void TargetGenerator::FillOutputs() {
const Value* value = scope_->GetValue(variables::kOutputs, true);
if (!value)
« no previous file with comments | « tools/gn/target_generator.h ('k') | tools/gn/toolchain.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698