Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: tools/gn/target.h

Issue 206813002: Remove GN GYP generator. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/secondary/ui/BUILD.gn ('k') | tools/gn/target.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/target.h
diff --git a/tools/gn/target.h b/tools/gn/target.h
index 2cf0409fa5841682269101c8566fb8a21c2193de..5e257ec3e53c6c428ed152281f224ea53feb5335 100644
--- a/tools/gn/target.h
+++ b/tools/gn/target.h
@@ -121,9 +121,6 @@ class Target : public Item {
return forward_dependent_configs_;
}
- bool external() const { return external_; }
- void set_external(bool e) { external_ = e; }
-
const std::set<const Target*>& inherited_libraries() const {
return inherited_libraries_;
}
@@ -138,9 +135,6 @@ class Target : public Item {
const OrderedSet<SourceDir>& all_lib_dirs() const { return all_lib_dirs_; }
const OrderedSet<std::string>& all_libs() const { return all_libs_; }
- const SourceFile& gyp_file() const { return gyp_file_; }
- void set_gyp_file(const SourceFile& gf) { gyp_file_ = gf; }
-
private:
// Pulls necessary information from dependents to this one when all
// dependencies have been resolved.
@@ -190,8 +184,6 @@ class Target : public Item {
ConfigValues config_values_; // Used for all binary targets.
ActionValues action_values_; // Used for action[_foreach] targets.
- SourceFile gyp_file_;
-
DISALLOW_COPY_AND_ASSIGN(Target);
};
« no previous file with comments | « tools/gn/secondary/ui/BUILD.gn ('k') | tools/gn/target.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698