Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(835)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2068123002: Add Swarming task for downloading Android SDK on Skia bots (Closed)

Created:
4 years, 6 months ago by borenet2
Modified:
4 years, 6 months ago
Reviewers:
borenet, rmistry, rmistry1
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add Swarming task for downloading Android SDK on Skia bots BUG=skia:5427, skia:5353 Committed: https://chromium.googlesource.com/chromium/tools/build/+/c6147d4e2ae34d2c825415db766d0731e8108825

Patch Set 1 #

Patch Set 2 : Fixes #

Patch Set 3 : Support legacy+fallback #

Patch Set 4 : Fixes #

Patch Set 5 : Fix missing hash #

Patch Set 6 : undo recipes.isolate change #

Total comments: 4

Patch Set 7 : Shrink the download_asset isolate #

Patch Set 8 : Only isolate gsutil #

Patch Set 9 : Expectations, fix names #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+1478 lines, -105 lines) Patch
A scripts/slave/recipes/skia/gsutil.isolate View 1 2 3 4 5 6 7 1 chunk +8 lines, -0 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.py View 1 2 3 4 5 6 7 8 6 chunks +83 lines, -21 lines 2 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Mac-Clang-x86_64-Release.json View 1 2 3 4 5 6 7 8 2 chunks +56 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Debug.json View 1 2 3 4 5 6 7 8 2 chunks +56 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Ubuntu-GCC-x86_64-Release-Trybot.json View 1 2 3 4 5 6 7 8 2 chunks +56 lines, -1 line 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win-MSVC-x86_64-Release.json View 1 2 3 4 5 6 7 8 3 chunks +57 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Build-Win-MSVC-x86_64-Release-Vulkan.json View 1 2 3 4 5 6 7 8 3 chunks +57 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Housekeeper-PerCommit.json View 1 2 3 4 5 6 7 8 6 chunks +61 lines, -5 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Missing_android_sdk_hash.json View 1 2 3 4 5 6 7 8 3 chunks +57 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/No_downloaded_SKP_VERSION.json View 1 2 3 4 5 6 7 8 7 chunks +61 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Perf-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Release-Trybot.json View 1 2 3 4 5 6 7 8 5 chunks +59 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Android-GCC-Nexus7v2-GPU-Tegra3-Arm7-Release.json View 1 2 3 4 5 6 7 8 7 chunks +272 lines, -11 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Mac-Clang-MacMini6.2-CPU-AVX-x86_64-Release.json View 1 2 3 4 5 6 7 8 5 chunks +59 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-Clang-GCE-CPU-AVX2-x86_64-Coverage-Trybot.json View 1 2 3 4 5 6 7 8 3 chunks +57 lines, -2 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug.json View 1 2 3 4 5 6 7 8 7 chunks +61 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-MSAN.json View 1 2 3 4 5 6 7 8 7 chunks +61 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Ubuntu-GCC-ShuttleA-GPU-GTX550Ti-x86_64-Release-Valgrind.json View 1 2 3 4 5 6 7 8 7 chunks +61 lines, -6 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleA-GPU-HD7770-x86_64-Release.json View 1 2 3 4 5 6 7 8 5 chunks +59 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-Win8-MSVC-ShuttleB-CPU-AVX2-x86_64-Release.json View 1 2 3 4 5 6 7 8 5 chunks +59 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Test-iOS-Clang-iPad4-GPU-SGX554-Arm7-Release.json View 1 2 3 4 5 6 7 8 5 chunks +59 lines, -4 lines 0 comments Download
M scripts/slave/recipes/skia/swarm_trigger.expected/Wrong_downloaded_SKP_VERSION.json View 1 2 3 4 5 6 7 8 7 chunks +61 lines, -6 lines 0 comments Download
A + scripts/slave/recipes/skia/swarm_trigger.expected/legacy_android_sdk.json View 1 2 3 4 5 6 7 8 2 chunks +58 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (6 generated)
borenet
Required for https://codereview.chromium.org/2067133003/ which also depends on https://codereview.chromium.org/2069543002/
4 years, 6 months ago (2016-06-15 13:18:46 UTC) #2
rmistry
lgtm https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py#newcode523 scripts/slave/recipes/skia/swarm_trigger.py:523: {'ASSET': asset, 'GSUTIL': '../../depot_tools/gsutil.py'}, Instead of hardcoding gsutil.py ...
4 years, 6 months ago (2016-06-15 13:51:32 UTC) #4
borenet
https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py#newcode523 scripts/slave/recipes/skia/swarm_trigger.py:523: {'ASSET': asset, 'GSUTIL': '../../depot_tools/gsutil.py'}, On 2016/06/15 13:51:31, rmistry wrote: ...
4 years, 6 months ago (2016-06-15 19:53:23 UTC) #5
rmistry
lgtm https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py#newcode523 scripts/slave/recipes/skia/swarm_trigger.py:523: {'ASSET': asset, 'GSUTIL': '../../depot_tools/gsutil.py'}, On 2016/06/15 19:53:23, borenet ...
4 years, 6 months ago (2016-06-15 20:11:00 UTC) #6
borenet
https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2068123002/diff/90001/scripts/slave/recipes/skia/swarm_trigger.py#newcode523 scripts/slave/recipes/skia/swarm_trigger.py:523: {'ASSET': asset, 'GSUTIL': '../../depot_tools/gsutil.py'}, On 2016/06/15 20:11:00, rmistry wrote: ...
4 years, 6 months ago (2016-06-15 20:25:09 UTC) #7
borenet
Shrunk the input isolate. +martiniss for recipes.isolate and depot_tools.isolate
4 years, 6 months ago (2016-06-16 07:54:03 UTC) #9
borenet
Shrink even more: just use a custom .isolate for only the gsutil-related parts of depot_tools.
4 years, 6 months ago (2016-06-16 08:22:54 UTC) #11
rmistry
lgtm https://codereview.chromium.org/2068123002/diff/150001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2068123002/diff/150001/scripts/slave/recipes/skia/swarm_trigger.py#newcode581 scripts/slave/recipes/skia/swarm_trigger.py:581: # TODO(borenet): Remove this legacy method after 7/1/2016. ...
4 years, 6 months ago (2016-06-16 12:34:20 UTC) #12
borenet
https://codereview.chromium.org/2068123002/diff/150001/scripts/slave/recipes/skia/swarm_trigger.py File scripts/slave/recipes/skia/swarm_trigger.py (right): https://codereview.chromium.org/2068123002/diff/150001/scripts/slave/recipes/skia/swarm_trigger.py#newcode581 scripts/slave/recipes/skia/swarm_trigger.py:581: # TODO(borenet): Remove this legacy method after 7/1/2016. On ...
4 years, 6 months ago (2016-06-16 19:25:37 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068123002/150001
4 years, 6 months ago (2016-06-16 19:25:55 UTC) #15
commit-bot: I haz the power
Committed patchset #9 (id:150001) as https://chromium.googlesource.com/chromium/tools/build/+/c6147d4e2ae34d2c825415db766d0731e8108825
4 years, 6 months ago (2016-06-16 19:29:55 UTC) #17
borenet
4 years, 6 months ago (2016-06-21 15:05:06 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #9 id:150001) has been created in
https://codereview.chromium.org/2087853002/ by borenet@google.com.

The reason for reverting is: Taking a different approach..

Powered by Google App Engine
This is Rietveld 408576698