Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 2068103003: Reland of Make default media device ID salts random by default (Closed)

Created:
4 years, 6 months ago by Guido Urdaneta
Modified:
4 years, 6 months ago
Reviewers:
jam
CC:
anandc+watch-blimp_chromium.org, android-webview-reviews_chromium.org, Avi (use Gerrit), chromium-reviews, darin-cc_chromium.org, dtrainor+watch-blimp_chromium.org, feature-media-reviews_chromium.org, haibinlu, jessicag+watch-blimp_chromium.org, jochen+watch_chromium.org, khushalsagar+watch-blimp_chromium.org, Kevin M, kmarshall+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, mcasas+watch+vc_chromium.org, mkwst+moarreviews-shell_chromium.org, mlamouri+watch-content_chromium.org, nyquist+watch-blimp_chromium.org, Peter Beverloo, shaktisahu+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, tommi (sloooow) - chröme, Torne, jochen (gone - plz use gerrit)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Make default media device ID salts random by default (patchset #1 id:1 of https://codereview.chromium.org/2065383003/ ) Reason for revert: Creating reland. The problem was a test that gets the salt on the IO thread. It should be changed to the UI thread. Original issue's description: > Revert of Make default media device ID salts random by default (patchset #13 id:260001 of https://codereview.chromium.org/1987643002/ ) > > Reason for revert: > Reverting because it is breaking the WebRTC MacTester bot. > https://build.chromium.org/p/chromium.webrtc/builders/Mac%20Tester/builds/55969/ > > Original issue's description: > > This results in different hashed device IDs on each session on embedders that don't have a specialized implementation of device ID salts such as WebView, Blimp and Content Shell. The new default helps prevent user fingerprinting on these embedders. > > > > Since the new default logic is basically the same as for Chrome incognito mode, Chrome's implementation of salts has been updated to defer to the new default on incognito mode. > > > > BUG=315022 > > > > Committed: https://crrev.com/4db1329e005388540eb07429ac97827ca9bc422b > > Cr-Commit-Position: refs/heads/master@{#399883} > > TBR=jam@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=315022 > > Committed: https://crrev.com/f72bda81d0c3e6f256826e9ecdf6d745e4ad76c8 > Cr-Commit-Position: refs/heads/master@{#399887} TBR=jam@chromium.org BUG=315022 Committed: https://crrev.com/91768ed181acd514b5d57af73477e69e7a927b6e Cr-Commit-Position: refs/heads/master@{#399902}

Patch Set 1 #

Patch Set 2 : Fix WebRTCAudioPrivateTest #

Unified diffs Side-by-side diffs Delta from patch set Stats (+167 lines, -224 lines) Patch
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.h View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/media/media_device_id_salt.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/media/media_device_id_salt.cc View 1 3 chunks +11 lines, -30 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.h View 1 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/profiles/profile_io_data.cc View 1 3 chunks +10 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host.cc View 1 4 chunks +10 lines, -12 lines 0 comments Download
M content/browser/renderer_host/media/audio_renderer_host_unittest.cc View 1 3 chunks +7 lines, -13 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 4 chunks +9 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 1 6 chunks +12 lines, -14 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 22 chunks +36 lines, -46 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 1 5 chunks +13 lines, -21 lines 0 comments Download
M content/browser/resource_context_impl.cc View 1 4 chunks +14 lines, -13 lines 0 comments Download
M content/public/browser/media_device_id.h View 1 1 chunk +7 lines, -8 lines 0 comments Download
M content/public/browser/media_device_id.cc View 1 2 chunks +6 lines, -9 lines 0 comments Download
M content/public/browser/resource_context.h View 1 1 chunk +11 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Guido Urdaneta
Created Reland of Make default media device ID salts random by default
4 years, 6 months ago (2016-06-15 13:40:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068103003/310001
4 years, 6 months ago (2016-06-15 13:45:48 UTC) #4
Guido Urdaneta
PS1 contains the originally landed code. PS2 contains the fix, which is substiting UI for ...
4 years, 6 months ago (2016-06-15 13:48:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:310001)
4 years, 6 months ago (2016-06-15 15:50:08 UTC) #7
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 15:50:12 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 15:51:35 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/91768ed181acd514b5d57af73477e69e7a927b6e
Cr-Commit-Position: refs/heads/master@{#399902}

Powered by Google App Engine
This is Rietveld 408576698