Make first-letter style to work with editing

Source/core/dom/PositionIterator.cpp

 /*
  * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 13 matching lines @@
  */
 
 #include "config.h"
 #include "core/dom/PositionIterator.h"
 
 #include "HTMLNames.h"
 #include "core/dom/Node.h"
 #include "core/editing/htmlediting.h"
 #include "core/html/HTMLHtmlElement.h"
 #include "core/rendering/RenderBlock.h"
+#include "core/rendering/RenderTextFragment.h"
 
 namespace WebCore {
 
 using namespace HTMLNames;
 
 PositionIterator::operator Position() const
 {
     if (m_nodeAfterPositionInAnchor) {
         ASSERT(m_nodeAfterPositionInAnchor->parentNode() == m_anchorNode);
         // FIXME: This check is inadaquete because any ancestor could be ignored by editing
@@ skipping 52 matching lines @@
     } else {
         if (m_offsetInAnchor)
             m_offsetInAnchor = Position::uncheckedPreviousOffset(m_anchorNode, m_offsetInAnchor);
         else {
             m_nodeAfterPositionInAnchor = m_anchorNode;
             m_anchorNode = m_anchorNode->parentNode();
         }
     }
 }
 
+RenderObject* PositionIterator::renderer() const

[ojan, 2013/09/23 23:01:45]

This is confusing since it's only the renderer of the anchorNode. Since this is
called from only once place, I'm not sure this function provides much value. I'd
just inline this code into PositionIterator::isCandidate.

+{
+    if (!m_anchorNode)

[ojan, 2013/09/23 23:01:45]

This null check is redundant with the one in PositionIterator::isCandidate.

+        return 0;
+    Position pos = *this;
+    return pos.rendererOfAnchorNode();
+}
+
 bool PositionIterator::atStart() const
 {
     if (!m_anchorNode)
         return true;
     if (m_anchorNode->parentNode())
         return false;
     return (!m_anchorNode->hasChildNodes() && !m_offsetInAnchor) || (m_nodeAfterPositionInAnchor && !m_nodeAfterPositionInAnchor->previousSibling());
 }
 
 bool PositionIterator::atEnd() const
@@ skipping 21 matching lines @@
     if (m_nodeAfterPositionInAnchor)
         return false;
     return m_anchorNode->hasChildNodes() || m_offsetInAnchor >= lastOffsetForEditing(m_anchorNode);
 }
 
 bool PositionIterator::isCandidate() const
 {
     if (!m_anchorNode)
         return false;
 
-    RenderObject* renderer = m_anchorNode->renderer();
+    RenderObject* renderer = this->renderer();
     if (!renderer)
         return false;
 
     if (renderer->style()->visibility() != VISIBLE)
         return false;
 
     if (renderer->isBR())
         return !m_offsetInAnchor && !Position::nodeIsUserSelectNone(m_anchorNode->parentNode());
 
     if (renderer->isText())
         return !Position::nodeIsUserSelectNone(m_anchorNode) && Position(*this).inRenderedText();
 
     if (isTableElement(m_anchorNode) || editingIgnoresContent(m_anchorNode))
         return (atStartOfNode() || atEndOfNode()) && !Position::nodeIsUserSelectNone(m_anchorNode->parentNode());
 
     if (!isHTMLHtmlElement(m_anchorNode) && renderer->isRenderBlockFlow()) {
         if (toRenderBlock(renderer)->logicalHeight() || m_anchorNode->hasTagName(bodyTag)) {
             if (!Position::hasRenderedNonAnonymousDescendantsWithHeight(renderer))
                 return atStartOfNode() && !Position::nodeIsUserSelectNone(m_anchorNode);
             return m_anchorNode->rendererIsEditable() && !Position::nodeIsUserSelectNone(m_anchorNode) && Position(*this).atEditingBoundary();
         }
     }
 
     return false;
 }
 
 } // namespace WebCore