Use platform.processor to figure out if we're in a VM.

Use platform.processor to figure out if we're in a VM.

BUG=chromium:609001
TEST=testScreenshotWithPrefix

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/91122c7ad6ee5366777f1aa221fd6140f7ceabc7

[achuithb, 2016-06-15 00:18:40]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 00:18:43]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2068063002/1

[commit-bot: I haz the power, 2016-06-15 00:43:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 00:43:16]

Dry run: This issue passed the CQ dry run.

[achuithb, 2016-06-15 08:27:02]

achuith@chromium.org changed reviewers:
+ jdufault@chromium.org

[achuithb, 2016-06-15 08:27:02]

Jake, please take a look

[jdufault, 2016-06-15 17:07:10]

lgtm, platform.processor is more reliable than reading from
/sys/class/dmi/id/sys_vendor?

[jdufault, 2016-06-15 17:08:16]

On 2016/06/15 17:07:10, jdufault wrote:
> lgtm, platform.processor is more reliable than reading from
> /sys/class/dmi/id/sys_vendor?

reliable at identifying that it's a VM*

[achuithb, 2016-06-15 17:43:10]

On 2016/06/15 17:07:10, jdufault wrote:
> lgtm, platform.processor is more reliable than reading from
> /sys/class/dmi/id/sys_vendor?

Yup, this check doesn't work. I suspect it's because /sys/class/dmi is a
symlink, but not sure. This works on local VMs (using qemu-kvm) but not on the
bots - I suspect we're not using kvm on the bots.

[achuithb, 2016-06-15 18:14:19]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2016-06-15 18:14:19]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/2068063002/#ps20001
(title: "rebase")

[commit-bot: I haz the power, 2016-06-15 18:14:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2068063002/20001

[commit-bot: I haz the power, 2016-06-15 18:39:17]

Description was changed from

==========
Use platform.processor to figure out if we're in a VM.

BUG=chromium:609001
TEST=testScreenshotWithPrefix
==========

to

==========
Use platform.processor to figure out if we're in a VM.

BUG=chromium:609001
TEST=testScreenshotWithPrefix

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-06-15 18:39:18]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

[achuithb, 2016-06-16 21:30:06]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2079563002/ by achuith@chromium.org.

The reason for reverting is: crbug.com/620798, looks like the wrong platform is
being imported.