third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp - Issue 2068053002: Rename Blink constants generated from IDL files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

Issue 2068053002: Rename Blink constants generated from IDL files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unintended exception message change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLTrackElement.h ('K') | « third_party/WebKit/Source/modules/webgl/WebGLDebugRendererInfo.h ('k') | third_party/WebKit/Source/modules/websockets/DOMWebSocket.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

diff --git a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

index ff1a4fe3ed692ea8398b4c0c2d924da8b000a62c..140d3146e3788081ce6cdafd1f298a44acc45eea 100644

--- a/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

+++ b/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp

@@ -2917,12 +2917,12 @@ ScriptValue WebGLRenderingContextBase::getParameter(ScriptState* scriptState, GL

return getUnsignedIntParameter(scriptState, GL_FRAGMENT_SHADER_DERIVATIVE_HINT_OES);

synthesizeGLError(GL_INVALID_ENUM, "getParameter", "invalid parameter name, OES_standard_derivatives not enabled");

return ScriptValue::createNull(scriptState);

- case WebGLDebugRendererInfo::UNMASKED_RENDERER_WEBGL:

+ case WebGLDebugRendererInfo::kUnmaskedRendererWebgl:

if (extensionEnabled(WebGLDebugRendererInfoName))

return WebGLAny(scriptState, String(contextGL()->GetString(GL_RENDERER)));

synthesizeGLError(GL_INVALID_ENUM, "getParameter", "invalid parameter name, WEBGL_debug_renderer_info not enabled");

return ScriptValue::createNull(scriptState);

- case WebGLDebugRendererInfo::UNMASKED_VENDOR_WEBGL:

+ case WebGLDebugRendererInfo::kUnmaskedVendorWebgl:

if (extensionEnabled(WebGLDebugRendererInfoName))

return WebGLAny(scriptState, String(contextGL()->GetString(GL_VENDOR)));

synthesizeGLError(GL_INVALID_ENUM, "getParameter", "invalid parameter name, WEBGL_debug_renderer_info not enabled");