third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp - Issue 2068053002: Rename Blink constants generated from IDL files.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

Issue 2068053002: Rename Blink constants generated from IDL files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix unintended exception message change Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/html/HTMLTrackElement.h ('K') | « third_party/WebKit/Source/modules/filesystem/WorkerGlobalScopeFileSystem.cpp ('k') | third_party/WebKit/Source/modules/geolocation/Geolocation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

diff --git a/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp b/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

index 31e83bb151fa61ca5877db1a5ab4d7896526114e..811feb3f01553cc5321dff8a23dd93980a66fdf6 100644

--- a/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

+++ b/third_party/WebKit/Source/modules/geolocation/GeoNotifier.cpp

@@ -98,7 +98,7 @@ void GeoNotifier::timerFired(Timer<GeoNotifier>*)

}

if (m_errorCallback)

- m_errorCallback->handleEvent(PositionError::create(PositionError::TIMEOUT, "Timeout expired"));

+ m_errorCallback->handleEvent(PositionError::create(PositionError::kTimeout, "Timeout expired"));

DEFINE_STATIC_LOCAL(CustomCountHistogram, timeoutExpiredHistogram, ("Geolocation.TimeoutExpired", 0, 1000 * 60 * 10 /* 10 minute max */, 20 /* buckets */));

timeoutExpiredHistogram.count(m_options.timeout());