Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2068033002:
Do not use IOSurface copyTexImage2D workaround for LUMA formats. (Closed)
DescriptionDo not use IOSurface copyTexImage2D workaround for LUMA formats.
copyTexImage is implemented for LUMA formats using a blit. Thus, there's no need
to use the copyTexImage2D workaround for IOSurfaces.
BUG=577144, 620067
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/1474859b3ba1100e4a80802f5a47bdd3934cb0f2
Cr-Commit-Position: refs/heads/master@{#399825}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Comments from zmo. #Messages
Total messages: 19 (8 generated)
Description was changed from ========== Do not use IOSurface copyTexImage2D workaround for LUMA formats. copyTexImage is implemented for LUMA formats using a blit. Thus, there's no need to use the copyTexImage2D workaround for IOSurfaces. BUG=577144, 620067 ========== to ========== Do not use IOSurface copyTexImage2D workaround for LUMA formats. copyTexImage is implemented for LUMA formats using a blit. Thus, there's no need to use the copyTexImage2D workaround for IOSurfaces. BUG=577144, 620067 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068033002/1
erikchen@chromium.org changed reviewers: + geofflang@chromium.org, zmo@chromium.org
zmo: Please review.
On 2016/06/14 21:48:23, erikchen wrote: > zmo: Please review. This is a better fix than I had, LGTM from me (non-owner)
lgtm https://codereview.chromium.org/2068033002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2068033002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:12447: } else if(use_workaround) { nit: a space after if.
https://codereview.chromium.org/2068033002/diff/1/gpu/command_buffer/service/... File gpu/command_buffer/service/gles2_cmd_decoder.cc (right): https://codereview.chromium.org/2068033002/diff/1/gpu/command_buffer/service/... gpu/command_buffer/service/gles2_cmd_decoder.cc:12447: } else if(use_workaround) { On 2016/06/14 22:49:14, Zhenyao Mo wrote: > nit: a space after if. Done.
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from zmo@chromium.org, geofflang@chromium.org Link to the patchset: https://codereview.chromium.org/2068033002/#ps20001 (title: "Comments from zmo.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068033002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2068033002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Do not use IOSurface copyTexImage2D workaround for LUMA formats. copyTexImage is implemented for LUMA formats using a blit. Thus, there's no need to use the copyTexImage2D workaround for IOSurfaces. BUG=577144, 620067 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Do not use IOSurface copyTexImage2D workaround for LUMA formats. copyTexImage is implemented for LUMA formats using a blit. Thus, there's no need to use the copyTexImage2D workaround for IOSurfaces. BUG=577144, 620067 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/1474859b3ba1100e4a80802f5a47bdd3934cb0f2 Cr-Commit-Position: refs/heads/master@{#399825} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1474859b3ba1100e4a80802f5a47bdd3934cb0f2 Cr-Commit-Position: refs/heads/master@{#399825} |
