Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(958)

Issue 2067993002: Revert of Do not suppress referrers for '<a ... rel="noopener">'. (Closed)

Created:
4 years, 6 months ago by hcarmona
Modified:
4 years, 5 months ago
CC:
blink-reviews, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, gavinp+loader_chromium.org, jam, Nate Chapin, kinuko+watch, loading-reviews_chromium.org, nasko+codewatch_chromium.org, tyoshino+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Do not suppress referrers for '<a ... rel="noopener">'. (patchset #1 id:1 of https://codereview.chromium.org/2058693002/ ) Reason for revert: Reverting for http://crbug.com/619856 Original issue's description: > Do not suppress referrers for '<a ... rel="noopener">'. > > The current implementation of 'noopener' correctly split the referrer > and opener states in Blink, but missed a spot higher up the stack where > the two were still conflated. This patch fixes that issue, adds tests > to ensure we don't regress, and refactors the Blink-side code a bit so > that we're no longer passing the data around twice. > > BUG=618532 > CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation > > Committed: https://crrev.com/4c82bb5386376f64c2a8eb9258ea397cba04b7d1 > Cr-Commit-Position: refs/heads/master@{#399391} TBR=jochen@chromium.org,mkwst@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=618532

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -40 lines) Patch
M content/browser/frame_host/render_frame_host_manager_browsertest.cc View 3 chunks +1 line, -21 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/EmptyClients.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/ChromeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/page/CreateWindow.cpp View 7 chunks +10 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
hcarmona
Created Revert of Do not suppress referrers for '<a ... rel="noopener">'.
4 years, 6 months ago (2016-06-14 19:38:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067993002/1
4 years, 6 months ago (2016-06-14 19:38:49 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/238947)
4 years, 6 months ago (2016-06-14 21:02:49 UTC) #5
hcarmona
4 years, 5 months ago (2016-07-06 21:34:44 UTC) #6
Trybots failed, so revert didn't land. This revert was created while sheriffing
in order to fix a build issue. The issue was on a separate branch and a revert
CL was landed there. This CL doesn't need to be committed. I forgot to close
this at that time, closing now.

Powered by Google App Engine
This is Rietveld 408576698