Expand WidthCache for complex text width queries

Expand WidthCache for complex text width queries

Expand use of WidthCache to apply to all complex text width queries.
It'll still bail out for queries where the GlyphOverflow bounds are
needed.

BUG=347186
R=dominik.rottsches@intel.com

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169800

[Dominik Röttsches, 2014-03-21 06:24:47]

Thanks for addressing this!

https://codereview.chromium.org/206793005/diff/20001/Source/platform/fonts/Fo...
File Source/platform/fonts/Font.cpp (right):

https://codereview.chromium.org/206793005/diff/20001/Source/platform/fonts/Fo...
Source/platform/fonts/Font.cpp:154: if (codePathToUse == ComplexPath ||
hasKerningOrLigatures) {
Now the decision on whether the cache is used is in two places. Perhaps it's
better to only have one, by either adding a "isComplexPath" parameter to the add
function or remove all parameters and move all conditions into this line here.

[eae, 2014-03-21 16:43:04]

On 2014/03/21 06:24:47, Dominik Röttsches wrote:
> Thanks for addressing this!
> 
>
https://codereview.chromium.org/206793005/diff/20001/Source/platform/fonts/Fo...
> File Source/platform/fonts/Font.cpp (right):
> 
>
https://codereview.chromium.org/206793005/diff/20001/Source/platform/fonts/Fo...
> Source/platform/fonts/Font.cpp:154: if (codePathToUse == ComplexPath ||
> hasKerningOrLigatures) {
> Now the decision on whether the cache is used is in two places. Perhaps it's
> better to only have one, by either adding a "isComplexPath" parameter to the
add
> function or remove all parameters and move all conditions into this line here.

Good points, I'll change it to have all the logic in Font.cpp as suggested.

[eae, 2014-03-21 17:09:04]

Please take another look.

[Dominik Röttsches, 2014-03-22 09:06:31]

LGTM!

[eae, 2014-03-22 17:01:45]

The CQ bit was checked by eae@chromium.org

[commit-bot: I haz the power, 2014-03-22 17:01:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/eae@chromium.org/206793005/40001

[commit-bot: I haz the power, 2014-03-22 20:57:34]

Change committed as 169800