Add 'colno' attribute to ErrorEvent interface

Add 'colno' attribute to ErrorEvent interface

Add 'colno' attribute to ErrorEvent interface to match the latest
specification:
http://www.whatwg.org/specs/web-apps/current-work/multipage/webappapis.html#errorevent

The 'colno' attribute is already supported by IE10.

BUG=264197
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155148

[do-not-use, 2013-07-26 07:48:55]

Note1: an intent to implement/ship was sent by Mike West to blink-dev.

Note2: The spec was updated to use 'colno' instead of 'column', thus matching
IE10:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22800

[Mike West, 2013-07-26 08:32:39]

LGTM, thanks for taking care of this. Now that the spec has changed to match
IE10, I don't think you need to wait for LGTMs on the blink-dev thread for this
bit.

[haraken, 2013-07-26 10:17:26]

In terms of implementation, LGTM.

[do-not-use, 2013-07-27 07:44:32]

An API Owner still needs to approve.

[tkent, 2013-07-28 21:52:11]

https://codereview.chromium.org/20679002/diff/1/LayoutTests/fast/events/const...
File LayoutTests/fast/events/constructors/error-event-constructor.html (right):

https://codereview.chromium.org/20679002/diff/1/LayoutTests/fast/events/const...
LayoutTests/fast/events/constructors/error-event-constructor.html:79:
shouldBe("new ErrorEvent('eventType', { colno: 0 }).colno", "0");
According to the specification, the member name of ErrorEventInit is 'column'
though an ErrorEvent attribute name is 'colno'. Is this a specification error?

[do-not-use, 2013-07-29 05:36:54]

On 2013/07/28 21:52:11, tkent wrote:
>
https://codereview.chromium.org/20679002/diff/1/LayoutTests/fast/events/const...
> File LayoutTests/fast/events/constructors/error-event-constructor.html
(right):
> 
>
https://codereview.chromium.org/20679002/diff/1/LayoutTests/fast/events/const...
> LayoutTests/fast/events/constructors/error-event-constructor.html:79:
> shouldBe("new ErrorEvent('eventType', { colno: 0 }).colno", "0");
> According to the specification, the member name of ErrorEventInit is 'column'
> though an ErrorEvent attribute name is 'colno'. Is this a specification error?

I believe so, 'column' was only renamed to 'colno' in the ErrorEvent interface
but not the ErrorEventInit dictionary. I think the editor simply overlooked that
one but we will know for sure soon:
https://www.w3.org/Bugs/Public/show_bug.cgi?id=22800#c6

[do-not-use, 2013-07-30 05:20:12]

https://codereview.chromium.org/20679002/diff/1/LayoutTests/fast/events/const...
File LayoutTests/fast/events/constructors/error-event-constructor.html (right):

https://codereview.chromium.org/20679002/diff/1/LayoutTests/fast/events/const...
LayoutTests/fast/events/constructors/error-event-constructor.html:79:
shouldBe("new ErrorEvent('eventType', { colno: 0 }).colno", "0");
On 2013/07/28 21:52:11, tkent wrote:
> According to the specification, the member name of ErrorEventInit is 'column'
> though an ErrorEvent attribute name is 'colno'. Is this a specification error?

The specification has now been fixed:
http://html5.org/tools/web-apps-tracker?from=8097&to=8098

[tkent, 2013-07-30 05:22:29]

lgtm

[commit-bot: I haz the power, 2013-07-30 05:55:00]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/20679002/1

[commit-bot: I haz the power, 2013-07-30 08:28:57]

Change committed as 155148

[arv (Not doing code reviews), 2013-07-31 16:07:23]

LGTM

https://chromiumcodereview.appspot.com/20679002/diff/1/LayoutTests/fast/event...
File LayoutTests/fast/events/window-onerror-08.html (right):

https://chromiumcodereview.appspot.com/20679002/diff/1/LayoutTests/fast/event...
LayoutTests/fast/events/window-onerror-08.html:17:
shouldBeEqualToString('window.event.type', 'error');
We should not be using window.event.

A better approach would have been to do:

var event;

window.addEventListener('error', function(e) {
    event = e;
});
....