Mixing audio with different latency requirements

media/base/audio_hardware_config_unittest.cc

Index: media/base/audio_hardware_config_unittest.cc
diff --git a/media/base/audio_hardware_config_unittest.cc b/media/base/audio_hardware_config_unittest.cc
index 2a493f157650dd58d49633fbcddc99581672ff76..3cf632312aacc96697f9117fd439664921f18a4f 100644
--- a/media/base/audio_hardware_config_unittest.cc
+++ b/media/base/audio_hardware_config_unittest.cc
@@ -88,42 +88,4 @@ TEST(AudioHardwareConfig, Setters) {
   EXPECT_EQ(kNewInputChannelLayout, fake_config.GetInputChannelLayout());
 }
 
-TEST(AudioHardwareConfig, HighLatencyBufferSizes) {

[chcunningham, 2016/06/22 04:34:07]

Are you planning to move this test to a new unit test file for AudioLatency?

[o1ka, 2016/06/23 16:36:16]

I think it makes more sense to add tests for mixer manager those ensure a mixer
with correct output parameters is created for an input with given audio
parameters and latency. Working on that.

[chcunningham, 2016/06/27 23:12:25]

Why not both? ¯\_(ツ)_/¯

These tests cover the math/platform nuances of the specific function. It depends
on what your plans are for the MixerManager... if you're going to exercise and
verify all the branches of this function in those tests then OK, but I think
thats probably a bit low level for the AudioMixerManager.

[o1ka, 2016/06/28 13:04:57]

:)) Agreed. Done.

-  AudioParameters input_params(AudioParameters::AUDIO_PCM_LOW_LATENCY,
-                               kInputChannelLayout,
-                               kInputSampleRate,
-                               16,
-                               kOutputBufferSize);
-  AudioParameters output_params(AudioParameters::AUDIO_PCM_LOW_LATENCY,
-                                kOutputChannelLayout,
-                                3200,
-                                16,
-                                32);
-  AudioHardwareConfig fake_config(input_params, output_params);
-
-#if defined(OS_WIN)
-  for (int i = 6400; i <= 204800; i *= 2) {
-    fake_config.UpdateOutputConfig(
-        AudioParameters(AudioParameters::AUDIO_PCM_LOW_LATENCY,
-                        kOutputChannelLayout,
-                        i,
-                        16,
-                        i / 100));
-    EXPECT_EQ(2 * (i / 100), fake_config.GetHighLatencyBufferSize());
-  }
-#else
-  EXPECT_EQ(64, fake_config.GetHighLatencyBufferSize());
-
-  for (int i = 6400; i <= 204800; i *= 2) {
-    fake_config.UpdateOutputConfig(
-        AudioParameters(AudioParameters::AUDIO_PCM_LOW_LATENCY,
-                        kOutputChannelLayout,
-                        i,
-                        16,
-                        32));
-    EXPECT_EQ(2 * (i / 100), fake_config.GetHighLatencyBufferSize());
-  }
-#endif  // defined(OS_WIN)
-}
-
 }  // namespace content