Mixing audio with different latency requirements

media/base/audio_renderer_mixer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/base/audio_renderer_mixer.h"
 
 #include <cmath>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/logging.h"
 #include "base/memory/ptr_util.h"
+#include "base/metrics/histogram_macros.h"
 
 namespace media {
 
 enum { kPauseDelaySeconds = 10 };
 
+// Tracks the maximum value of a counter and logs it into a UMA histogram upon
+// the destruciton.
+class AudioRendererMixer::UMAMaxValueTracker {
+ public:
+  UMAMaxValueTracker(const std::string& histogram_name)
+      : histogram_name_(histogram_name), count_(0), max_count_(0) {}
+
+  ~UMAMaxValueTracker() {
+    if (max_count_ && !histogram_name_.empty())
+      LOCAL_HISTOGRAM_CUSTOM_COUNTS(histogram_name_, max_count_, 1, 100, 100);

[tommi (sloooow) - chröme, 2016/06/28 14:14:54]

see other comment about using a variable here

[o1ka, 2016/06/29 10:11:26]

Done.

+  }
+
+  // Increments the counter, updates the maximum.
+  void Increment() {

[tommi (sloooow) - chröme, 2016/06/28 14:14:54]

thread checks?

[o1ka, 2016/06/29 10:11:26]

Updated a comment. It's used under a lock from multiple threads.

+    ++count_;
+    if (max_count_ < count_)
+      max_count_ = count_;
+  }
+
+  // Decrements the counter.
+  void Decrement() { --count_; }
+
+ private:
+  const std::string histogram_name_;

[tommi (sloooow) - chröme, 2016/06/28 14:14:54]

const char*

[o1ka, 2016/06/29 10:11:26]

Acknowledged.

+  int count_;
+  int max_count_;
+  DISALLOW_COPY_AND_ASSIGN(UMAMaxValueTracker);
+};
+
 AudioRendererMixer::AudioRendererMixer(const AudioParameters& output_params,
-                                       scoped_refptr<AudioRendererSink> sink)
+                                       scoped_refptr<AudioRendererSink> sink,
+                                       const std::string& histogram_name)
     : output_params_(output_params),
       audio_sink_(std::move(sink)),
       master_converter_(output_params, output_params, true),
       pause_delay_(base::TimeDelta::FromSeconds(kPauseDelaySeconds)),
       last_play_time_(base::TimeTicks::Now()),
       // Initialize |playing_| to true since Start() results in an auto-play.
-      playing_(true) {
+      playing_(true),
+      input_count_tracker_(new UMAMaxValueTracker(histogram_name)) {
   DCHECK(audio_sink_);
   audio_sink_->Initialize(output_params, this);
   audio_sink_->Start();
 }
 
 AudioRendererMixer::~AudioRendererMixer() {
   // AudioRendererSink must be stopped before mixer is destructed.
   audio_sink_->Stop();
 
   // Ensure that all mixer inputs have removed themselves prior to destruction.
@@ skipping 26 matching lines @@
                                      // size requests, disabling FIFO.
                                      new LoopbackAudioConverter(
                                          input_params, output_params_, true))));
       converter = result.first;
 
       // Add newly-created resampler as an input to the master mixer.
       master_converter_.AddInput(converter->second.get());
     }
     converter->second->AddInput(input);
   }
+
+  input_count_tracker_->Increment();
 }
 
 void AudioRendererMixer::RemoveMixerInput(
     const AudioParameters& input_params,
     AudioConverter::InputCallback* input) {
   base::AutoLock auto_lock(lock_);
 
   int input_sample_rate = input_params.sample_rate();
   if (is_master_sample_rate(input_sample_rate)) {
     master_converter_.RemoveInput(input);
   } else {
     AudioConvertersMap::iterator converter =
         converters_.find(input_sample_rate);
     DCHECK(converter != converters_.end());
     converter->second->RemoveInput(input);
     if (converter->second->empty()) {
       // Remove converter when it's empty.
       master_converter_.RemoveInput(converter->second.get());
       converters_.erase(converter);
     }
   }
+
+  input_count_tracker_->Decrement();
 }
 
 void AudioRendererMixer::AddErrorCallback(const base::Closure& error_cb) {
   base::AutoLock auto_lock(lock_);
   error_callbacks_.push_back(error_cb);
 }
 
 void AudioRendererMixer::RemoveErrorCallback(const base::Closure& error_cb) {
   base::AutoLock auto_lock(lock_);
   for (ErrorCallbackList::iterator it = error_callbacks_.begin();
@@ skipping 35 matching lines @@
 }
 
 void AudioRendererMixer::OnRenderError() {
   // Call each mixer input and signal an error.
   base::AutoLock auto_lock(lock_);
   for (const auto& cb : error_callbacks_)
     cb.Run();
 }
 
 }  // namespace media