net/http/http_network_session.cc - Issue 2067843003: Require a CTVerifier and CTPolicyEnforcer for TLS/QUIC sockets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/http/http_network_session.cc

Issue 2067843003: Require a CTVerifier and CTPolicyEnforcer for TLS/QUIC sockets (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Extensions Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« net/http/http_network_session.h ('K') | « net/http/http_network_session.h ('k') | net/http/http_network_transaction_ssl_unittest.cc » ('j') | net/http/http_stream_factory_impl_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: net/http/http_network_session.cc

diff --git a/net/http/http_network_session.cc b/net/http/http_network_session.cc

index 461cdd87d82b5b34df10b143b535a09ad829e70e..db3fd2cc216e1d74ab6a3c5a33db5c8a0a6bea8b 100644

--- a/net/http/http_network_session.cc

+++ b/net/http/http_network_session.cc

@@ -75,10 +75,10 @@ HttpNetworkSession::Params::Params()

: client_socket_factory(NULL),

host_resolver(NULL),

cert_verifier(NULL),

- ct_policy_enforcer(NULL),

channel_id_service(NULL),

transport_security_state(NULL),

cert_transparency_verifier(NULL),

+ ct_policy_enforcer(NULL),

Ryan Hamilton 2016/06/16 03:31:04 nullptr as long as you're here?

Ryan Sleevi 2016/06/16 21:29:17 Opted not to. File consistency should reign here -

proxy_service(NULL),

ssl_config_service(NULL),

http_auth_handler_factory(NULL),