ExitDetector: Don't short-circuit return on non-exiting case statements

ExitDetector: Don't short-circuit return on non-exiting case statements

BUG=https://github.com/dart-lang/sdk/issues/26677
R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/6b2c857cbb9f1d75d88916e24ac72bb3914e4807

[srawlins, 2016-06-14 16:08:38]

srawlins@google.com changed reviewers:
+ brianwilkerson@google.com

[Brian Wilkerson, 2016-06-14 16:27:15]

lgtm

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:3758: bool hasNonExitingCase;
nit: While not strictly necessary, I'd prefer all 'bool' valued variables be
initialized to a non-null value unless there's a really good reason not to.

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:3764: // If this is the last member
and there are no statements, return
nit: the code below no longer returns

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:3772: // otherwise, return false if
no return is found in the children
nit: the code below no longer returns

[srawlins, 2016-06-14 18:28:17]

Thanks!

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
File pkg/analyzer/lib/src/generated/resolver.dart (right):

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:3758: bool hasNonExitingCase;
On 2016/06/14 16:27:14, Brian Wilkerson wrote:
> nit: While not strictly necessary, I'd prefer all 'bool' valued variables be
> initialized to a non-null value unless there's a really good reason not to.

Done.

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:3764: // If this is the last member
and there are no statements, return
On 2016/06/14 16:27:15, Brian Wilkerson wrote:
> nit: the code below no longer returns

Done.

https://codereview.chromium.org/2067843002/diff/1/pkg/analyzer/lib/src/genera...
pkg/analyzer/lib/src/generated/resolver.dart:3772: // otherwise, return false if
no return is found in the children
On 2016/06/14 16:27:15, Brian Wilkerson wrote:
> nit: the code below no longer returns

Done.

[srawlins, 2016-06-14 18:31:32]

Description was changed from

==========
ExitDetector: Don't short-circuit return on non-exiting case statements

BUG=https://github.com/dart-lang/sdk/issues/26677
==========

to

==========
ExitDetector: Don't short-circuit return on non-exiting case statements

BUG=https://github.com/dart-lang/sdk/issues/26677
R=brianwilkerson@google.com

Committed:
https://github.com/dart-lang/sdk/commit/6b2c857cbb9f1d75d88916e24ac72bb3914e4807
==========

[srawlins, 2016-06-14 18:31:33]

Committed patchset #2 (id:20001) manually as
6b2c857cbb9f1d75d88916e24ac72bb3914e4807 (presubmit successful).