Remove PlatforFile from fileapi/native_file_util

webkit/browser/fileapi/native_file_util.h

Index: webkit/browser/fileapi/native_file_util.h
diff --git a/webkit/browser/fileapi/native_file_util.h b/webkit/browser/fileapi/native_file_util.h
index 7069c02eb6457fccdb8c395cff232f5911a517c8..fbe2122bf9c8d704a5220f43489997f93a71a103 100644
--- a/webkit/browser/fileapi/native_file_util.h
+++ b/webkit/browser/fileapi/native_file_util.h
@@ -9,7 +9,6 @@
 #include "base/files/file_path.h"
 #include "base/files/file_util_proxy.h"
 #include "base/memory/scoped_ptr.h"
-#include "base/platform_file.h"
 #include "webkit/browser/fileapi/file_system_file_util.h"
 #include "webkit/browser/webkit_storage_browser_export.h"
 
@@ -39,12 +38,9 @@ class WEBKIT_STORAGE_BROWSER_EXPORT_PRIVATE NativeFileUtil {
   static CopyOrMoveMode CopyOrMoveModeForDestination(
       const FileSystemURL& dest_url, bool copy);
 
-  static base::File::Error CreateOrOpen(

[rvargas (doing something else), 2014/03/21 22:39:21]

Actually I would prefer to return base::File instead even if it breaks the
overall symmetry of the class (although not every method currently returns
Error). It makes it absolutely explicit that there is a transfer of ownership
for the file (which is the overall objective), and it eliminates the small issue
about having two ways to do the same thing (return value vs.
file.error_details())

On the other hand, for something called CreateOrOpen, it is pretty clear (at
least to me) that |File* file| is an out argument and the owner is the caller.

BTW, a similar change to FileSystemFileUtil would follow.

[kinuko, 2014/03/24 09:56:58]

I'm fine with having this return base::File.

-      const base::FilePath& path,
-      int file_flags,
-      base::PlatformFile* file_handle,
-      bool* created);
-  static base::File::Error Close(base::PlatformFile file);
+  static base::File::Error CreateOrOpen(const base::FilePath& path,
+                                        int file_flags,
+                                        base::File* file);
   static base::File::Error EnsureFileExists(const base::FilePath& path,
                                             bool* created);
   static base::File::Error CreateDirectory(const base::FilePath& path,
@@ -59,7 +55,7 @@ class WEBKIT_STORAGE_BROWSER_EXPORT_PRIVATE NativeFileUtil {
                                  const base::Time& last_access_time,
                                  const base::Time& last_modified_time);
   static base::File::Error Truncate(const base::FilePath& path,
-                                          int64 length);
+                                    int64 length);
   static bool PathExists(const base::FilePath& path);
   static bool DirectoryExists(const base::FilePath& path);
   static base::File::Error CopyOrMoveFile(