Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2067823002: Fix flaking file lock test (Closed)

Created:
4 years, 6 months ago by zra
Modified:
4 years, 6 months ago
Reviewers:
Florian Schneider
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Remove delay #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M tests/standalone/io/file_blocking_lock_test.dart View 1 4 chunks +18 lines, -18 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 6 months ago (2016-06-14 15:04:11 UTC) #2
Florian Schneider
lgtm https://codereview.chromium.org/2067823002/diff/1/tests/standalone/io/file_blocking_lock_test.dart File tests/standalone/io/file_blocking_lock_test.dart (right): https://codereview.chromium.org/2067823002/diff/1/tests/standalone/io/file_blocking_lock_test.dart#newcode52 tests/standalone/io/file_blocking_lock_test.dart:52: await new Future.delayed(const Duration(seconds: 1)); Is this wait ...
4 years, 6 months ago (2016-06-14 16:46:51 UTC) #3
zra
Committed patchset #2 (id:20001) manually as c018cdf4e3a29eef590126c181da24dfe3899d8d (presubmit successful).
4 years, 6 months ago (2016-06-14 17:04:22 UTC) #5
zra
4 years, 6 months ago (2016-06-14 17:04:26 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/2067823002/diff/1/tests/standalone/io/file_bl...
File tests/standalone/io/file_blocking_lock_test.dart (right):

https://codereview.chromium.org/2067823002/diff/1/tests/standalone/io/file_bl...
tests/standalone/io/file_blocking_lock_test.dart:52: await new
Future.delayed(const Duration(seconds: 1));
On 2016/06/14 16:46:51, Florian Schneider wrote:
> Is this wait still necessary now with your change?

No. Removed.

Powered by Google App Engine
This is Rietveld 408576698