Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Issue 2067733002: Add MemoryLeakReportProto enum/field for type of process (Closed)

Created:
4 years, 6 months ago by Simon Que
Modified:
4 years, 6 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org, Will Harris
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add MemoryLeakReportProto enum/field for type of process This indicates whether the report was generated on a browser or a renderer process. BUG=chromium:615223 TEST=Build successfully R=isherman@chromium.org Committed: https://crrev.com/64bedd689c873ecf51fe9511e03010895c06f405 Cr-Commit-Position: refs/heads/master@{#400103}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Update tag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M components/metrics/proto/memory_leak_report.proto View 1 2 chunks +9 lines, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Simon Que
4 years, 6 months ago (2016-06-14 01:37:39 UTC) #1
Ilya Sherman
LGTM https://codereview.chromium.org/2067733002/diff/1/components/metrics/proto/memory_leak_report.proto File components/metrics/proto/memory_leak_report.proto (right): https://codereview.chromium.org/2067733002/diff/1/components/metrics/proto/memory_leak_report.proto#newcode11 components/metrics/proto/memory_leak_report.proto:11: // Next tag: 5 nit: Please update the ...
4 years, 6 months ago (2016-06-14 01:52:04 UTC) #2
Simon Que
https://codereview.chromium.org/2067733002/diff/1/components/metrics/proto/memory_leak_report.proto File components/metrics/proto/memory_leak_report.proto (right): https://codereview.chromium.org/2067733002/diff/1/components/metrics/proto/memory_leak_report.proto#newcode11 components/metrics/proto/memory_leak_report.proto:11: // Next tag: 5 On 2016/06/14 01:52:04, Ilya Sherman ...
4 years, 6 months ago (2016-06-16 01:17:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067733002/20001
4 years, 6 months ago (2016-06-16 01:18:35 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/128131)
4 years, 6 months ago (2016-06-16 02:44:53 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067733002/20001
4 years, 6 months ago (2016-06-16 07:33:06 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-16 07:37:22 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-16 07:37:28 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-16 07:38:38 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64bedd689c873ecf51fe9511e03010895c06f405
Cr-Commit-Position: refs/heads/master@{#400103}

Powered by Google App Engine
This is Rietveld 408576698