Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2067693002: Add chromeos test data dir for unit_tests (Closed)

Created:
4 years, 6 months ago by stevenjb
Modified:
4 years, 6 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add chromeos test data dir for unit_tests BUG=433082 Committed: https://crrev.com/07d5ad35d024d5181e6b4fae0587cfe66a6a0db1 Cr-Commit-Position: refs/heads/master@{#399654}

Patch Set 1 #

Patch Set 2 : patch -p 1 < ~/Downloads/issue1931033002_360001.diff #

Patch Set 3 : Remove builder patch #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M chrome/browser/chromeos/BUILD.gn View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
stevenjb
4 years, 6 months ago (2016-06-14 03:27:59 UTC) #2
Dirk Pranke
lgtm
4 years, 6 months ago (2016-06-14 04:21:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067693002/30001
4 years, 6 months ago (2016-06-14 04:44:46 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:30001)
4 years, 6 months ago (2016-06-14 06:33:03 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 06:33:11 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 06:36:00 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/07d5ad35d024d5181e6b4fae0587cfe66a6a0db1
Cr-Commit-Position: refs/heads/master@{#399654}

Powered by Google App Engine
This is Rietveld 408576698