drover win: Use --stdin so update-index doesn't fail on long cmdline

drover win: Use --stdin so update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808
Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/0205656321a66c2d2af5b71fad0caaa0f6391c27

[scottmg, 2016-06-13 21:41:32]

Description was changed from

==========
drover win: Use --stdin to update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808
==========

to

==========
drover win: Use --stdin to update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808
==========

[scottmg, 2016-06-13 21:41:32]

scottmg@chromium.org changed reviewers:
+ dpranke@chromium.org, iannucci@chromium.org

[scottmg, 2016-06-13 21:41:43]

Description was changed from

==========
drover win: Use --stdin to update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808
==========

to

==========
drover win: Use --stdin so update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808
==========

[iannucci, 2016-06-14 00:03:38]

lgtm, though I don't really own this code (see blamelist for more ownerly-type
folks).

https://chromiumcodereview.appspot.com/2067653002/diff/20001/git_drover.py
File git_drover.py (right):

https://chromiumcodereview.appspot.com/2067653002/diff/20001/git_drover.py#ne...
git_drover.py:271: stdin=extra_files_on_stdin)
I would inline extra_files_on_stdin, but that's just me.

https://chromiumcodereview.appspot.com/2067653002/diff/20001/git_drover.py#ne...
git_drover.py:340: popen.wait()
communicate implies wait

[scottmg, 2016-06-14 00:13:16]

https://codereview.chromium.org/2067653002/diff/20001/git_drover.py
File git_drover.py (right):

https://codereview.chromium.org/2067653002/diff/20001/git_drover.py#newcode271
git_drover.py:271: stdin=extra_files_on_stdin)
On 2016/06/14 00:03:38, iannucci wrote:
> I would inline extra_files_on_stdin, but that's just me.

Done.

https://codereview.chromium.org/2067653002/diff/20001/git_drover.py#newcode340
git_drover.py:340: popen.wait()
On 2016/06/14 00:03:38, iannucci wrote:
> communicate implies wait

Done.

[scottmg, 2016-06-14 00:14:11]

scottmg@chromium.org changed reviewers:
+ sammc@chromium.org

[scottmg, 2016-06-14 00:14:11]

+sammc if you have any more ownerly comments

[Sam McNally, 2016-06-14 00:24:52]

Thanks, LGTM

[scottmg, 2016-06-14 01:25:01]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-06-14 01:25:02]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2067653002/#ps40001
(title: "review fixes")

[commit-bot: I haz the power, 2016-06-14 01:25:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067653002/40001

[commit-bot: I haz the power, 2016-06-14 01:32:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 01:32:18]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[scottmg, 2016-06-14 17:48:23]

Patched up the mock tests if you could take another look.

[scottmg, 2016-06-14 18:23:05]

Patchset #4 (id:60001) has been deleted

[Sam McNally, 2016-06-15 04:43:00]

lgtm

[scottmg, 2016-06-15 16:39:59]

The CQ bit was checked by scottmg@chromium.org

[scottmg, 2016-06-15 16:39:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
iannucci@chromium.org
Link to the patchset: https://codereview.chromium.org/2067653002/#ps80001
(title: "fix mocky methods")

[commit-bot: I haz the power, 2016-06-15 16:40:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067653002/80001

[commit-bot: I haz the power, 2016-06-15 16:46:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 16:46:57]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[scottmg, 2016-06-15 18:42:13]

On 2016/06/15 16:46:57, commit-bot: I haz the power wrote:
> Try jobs failed on following builders:
>   Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
>
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

Not sure how I might have broken that test, so, uh, I'm going to try again.

[scottmg, 2016-06-15 18:42:17]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-06-15 18:42:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067653002/80001

[commit-bot: I haz the power, 2016-06-15 18:48:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 18:48:54]

Try jobs failed on following builders:
  Depot Tools Presubmit on tryserver.infra (JOB_FAILED,
https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubm...)

[scottmg, 2016-06-15 20:47:01]

It seems presubmit tests are just broken:
https://bugs.chromium.org/p/chromium/issues/detail?id=620411.

[scottmg, 2016-06-16 00:17:35]

On 2016/06/15 20:47:01, scottmg wrote:
> It seems presubmit tests are just broken:
> https://bugs.chromium.org/p/chromium/issues/detail?id=620411.

That yak is shaved, popping down to this one.

[scottmg, 2016-06-16 00:17:40]

The CQ bit was checked by scottmg@chromium.org

[commit-bot: I haz the power, 2016-06-16 00:17:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067653002/80001

[commit-bot: I haz the power, 2016-06-16 00:21:07]

Description was changed from

==========
drover win: Use --stdin so update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808
==========

to

==========
drover win: Use --stdin so update-index doesn't fail on long cmdline

git update-index would fail on long command lines when setting up
a resolve. Instead of passing all the files names on the command line,
pass them through --stdin and a file handle.

BUG=598808

Committed:
https://chromium.googlesource.com/chromium/tools/depot_tools/+/0205656321a66c...
==========

[commit-bot: I haz the power, 2016-06-16 00:21:09]

Committed patchset #4 (id:80001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/0205656321a66c...