Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2067583002: Revert of Update typeface serialization style. (Closed)

Created:
4 years, 6 months ago by mtklein
Modified:
4 years, 6 months ago
Reviewers:
bungeman-skia, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Update typeface serialization style. (patchset #3 id:40001 of https://codereview.chromium.org/2030683002/ ) Reason for revert: serialize-8888 broken for typefacestyles on Mac. (Bold weighting goes missing.) Original issue's description: > Update typeface serialization style. > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2030683002 > > Committed: https://skia.googlesource.com/skia/+/7ae1c72e593823e6e300e4199558555765bcec17 TBR=reed@google.com,bungeman@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/f8f9c07c283a3204a38b4324c14597e644686428

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -38 lines) Patch
M include/core/SkPicture.h View 1 chunk +1 line, -4 lines 0 comments Download
M src/core/SkFontDescriptor.h View 2 chunks +4 lines, -4 lines 0 comments Download
M src/core/SkFontDescriptor.cpp View 3 chunks +3 lines, -12 lines 0 comments Download
M src/core/SkTypeface.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M src/fonts/SkFontMgr_fontconfig.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/fonts/SkTestScalerContext.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_mac.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontHost_win.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontMgr_android.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontMgr_custom.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkFontMgr_fontconfig.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/ports/SkTypeface_win_dw.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M src/utils/SkWhitelistTypefaces.cpp View 5 chunks +7 lines, -8 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
mtklein
Created Revert of Update typeface serialization style.
4 years, 6 months ago (2016-06-13 18:27:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067583002/1
4 years, 6 months ago (2016-06-13 18:27:49 UTC) #3
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 18:27:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/f8f9c07c283a3204a38b4324c14597e644686428

Powered by Google App Engine
This is Rietveld 408576698