content/browser/dom_storage/dom_storage_context_impl.cc - Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/dom_storage/dom_storage_context_impl.cc

Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix include. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/dom_storage/dom_storage_area.cc ('K') | « content/browser/dom_storage/dom_storage_area.cc ('k') | content/browser/dom_storage/session_storage_database.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/dom_storage/dom_storage_context_impl.cc

diff --git a/content/browser/dom_storage/dom_storage_context_impl.cc b/content/browser/dom_storage/dom_storage_context_impl.cc

index e4ccfe0dec5f62f9f7117751b5856eee252c91e0..11b8ca5f4f33545b4d4f8952eb2cf75e65479f9d 100644

--- a/content/browser/dom_storage/dom_storage_context_impl.cc

+++ b/content/browser/dom_storage/dom_storage_context_impl.cc

@@ -4,6 +4,7 @@

#include "content/browser/dom_storage/dom_storage_context_impl.h"

+#include <inttypes.h>

#include <stddef.h>

#include <stdlib.h>

@@ -476,7 +477,8 @@ bool DOMStorageContextImpl::OnMemoryDump(

DOMStorageNamespace::UsageStatistics total_stats =

GetTotalNamespaceStatistics(namespaces_);

auto mad = pmd->CreateAllocatorDump(

- StringPrintf("dom_storage/%p/cache_size", this));

+ base::StringPrintf("dom_storage/0x%" PRIXPTR "/cache_size",

+ reinterpret_cast<uintptr_t>(this)));

mad->AddScalar(base::trace_event::MemoryAllocatorDump::kNameSize,

base::trace_event::MemoryAllocatorDump::kUnitsBytes,

total_stats.total_cache_size);