cc/tiles/software_image_decode_controller.cc - Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/tiles/software_image_decode_controller.cc

Issue 2067543003: [tracing] Replace %p with %PRIXPTR in the memory dump names (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix include. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « cc/tiles/gpu_image_decode_controller.cc ('k') | content/browser/dom_storage/dom_storage_area.cc » ('j') | content/browser/dom_storage/dom_storage_area.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/tiles/software_image_decode_controller.cc

diff --git a/cc/tiles/software_image_decode_controller.cc b/cc/tiles/software_image_decode_controller.cc

index ed433e8cc0a01a24da508ed86c4ae669b41b64b0..a44d7d0feecc309d5ebe748df60c1a1876a37815 100644

--- a/cc/tiles/software_image_decode_controller.cc

+++ b/cc/tiles/software_image_decode_controller.cc

@@ -4,6 +4,7 @@

#include "cc/tiles/software_image_decode_controller.h"

+#include <inttypes.h>

#include <stdint.h>

#include <algorithm>

@@ -707,9 +708,9 @@ void SoftwareImageDecodeController::DumpImageMemoryForCache(

for (const auto& image_pair : cache) {

std::string dump_name = base::StringPrintf(

- "cc/image_memory/controller_%p/%s/image_%" PRIu64 "_id_%d", this,

- cache_name, image_pair.second->tracing_id(),

- image_pair.first.image_id());

+ "cc/image_memory/controller_0x%" PRIXPTR "/%s/image_%" PRIu64 "_id_%d",

+ reinterpret_cast<uintptr_t>(this), cache_name,

+ image_pair.second->tracing_id(), image_pair.first.image_id());

base::trace_event::MemoryAllocatorDump* dump =

image_pair.second->memory()->CreateMemoryAllocatorDump(

dump_name.c_str(), pmd);