Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: src/interpreter/interpreter-assembler.cc

Issue 2067503002: [debugger] fix stepping over await calls for ignition generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@test
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/interpreter/interpreter-assembler.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/interpreter/interpreter-assembler.cc
diff --git a/src/interpreter/interpreter-assembler.cc b/src/interpreter/interpreter-assembler.cc
index d878c5c69370b4904e5963b81e6487f34d7a3ae7..9cd3b1902018ac4f12b62417f62c82fb01a5fc2d 100644
--- a/src/interpreter/interpreter-assembler.cc
+++ b/src/interpreter/interpreter-assembler.cc
@@ -620,6 +620,17 @@ Node* InterpreterAssembler::StackCheckTriggeredInterrupt() {
return UintPtrLessThan(sp, stack_limit);
}
+Node* InterpreterAssembler::DebugSteppingAcrossAwait() {
rmcilroy 2016/06/14 10:00:22 This is no longer a generic operation that might b
Yang 2016/06/14 11:19:44 Done.
+ Node* step_action =
+ Load(MachineType::Int8(),
+ ExternalConstant(
+ ExternalReference::debug_last_step_action_address(isolate())));
+ STATIC_ASSERT(StepIn > StepNext);
+ STATIC_ASSERT(StepFrame > StepNext);
rmcilroy 2016/06/14 10:00:22 Could you assert that StepFrame is the last elemen
Yang 2016/06/14 11:19:44 Done.
+ Node* step_next = Int32Constant(StepNext);
+ return Int32LessThanOrEqual(step_next, step_action);
+}
+
void InterpreterAssembler::Abort(BailoutReason bailout_reason) {
disable_stack_check_across_call_ = true;
Node* abort_id = SmiTag(Int32Constant(bailout_reason));
« no previous file with comments | « src/interpreter/interpreter-assembler.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698