Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: src/runtime/runtime-debug.cc

Issue 2067503002: [debugger] fix stepping over await calls for ignition generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@test
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/runtime/runtime.h ('k') | src/runtime/runtime-generator.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/runtime/runtime-utils.h" 5 #include "src/runtime/runtime-utils.h"
6 6
7 #include "src/arguments.h" 7 #include "src/arguments.h"
8 #include "src/debug/debug-evaluate.h" 8 #include "src/debug/debug-evaluate.h"
9 #include "src/debug/debug-frames.h" 9 #include "src/debug/debug-frames.h"
10 #include "src/debug/debug-scopes.h" 10 #include "src/debug/debug-scopes.h"
(...skipping 1691 matching lines...) Expand 10 before | Expand all | Expand 10 after
1702 } 1702 }
1703 1703
1704 // Set one shot breakpoints for the suspended generator object. 1704 // Set one shot breakpoints for the suspended generator object.
1705 RUNTIME_FUNCTION(Runtime_DebugPrepareStepInSuspendedGenerator) { 1705 RUNTIME_FUNCTION(Runtime_DebugPrepareStepInSuspendedGenerator) {
1706 HandleScope scope(isolate); 1706 HandleScope scope(isolate);
1707 DCHECK_EQ(0, args.length()); 1707 DCHECK_EQ(0, args.length());
1708 isolate->debug()->PrepareStepInSuspendedGenerator(); 1708 isolate->debug()->PrepareStepInSuspendedGenerator();
1709 return isolate->heap()->undefined_value(); 1709 return isolate->heap()->undefined_value();
1710 } 1710 }
1711 1711
1712 RUNTIME_FUNCTION(Runtime_DebugRecordAsyncFunction) {
1713 HandleScope scope(isolate);
1714 DCHECK_EQ(1, args.length());
1715 CONVERT_ARG_HANDLE_CHECKED(JSGeneratorObject, generator, 0);
1716 CHECK(isolate->debug()->last_step_action() >= StepNext);
1717 isolate->debug()->RecordAsyncFunction(generator);
1718 return isolate->heap()->undefined_value();
1719 }
1720
1712 RUNTIME_FUNCTION(Runtime_DebugPushPromise) { 1721 RUNTIME_FUNCTION(Runtime_DebugPushPromise) {
1713 DCHECK(args.length() == 2); 1722 DCHECK(args.length() == 2);
1714 HandleScope scope(isolate); 1723 HandleScope scope(isolate);
1715 CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0); 1724 CONVERT_ARG_HANDLE_CHECKED(JSObject, promise, 0);
1716 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 1); 1725 CONVERT_ARG_HANDLE_CHECKED(JSFunction, function, 1);
1717 isolate->PushPromise(promise, function); 1726 isolate->PushPromise(promise, function);
1718 return isolate->heap()->undefined_value(); 1727 return isolate->heap()->undefined_value();
1719 } 1728 }
1720 1729
1721 1730
(...skipping 19 matching lines...) Expand all
1741 return Smi::FromInt(isolate->debug()->is_active()); 1750 return Smi::FromInt(isolate->debug()->is_active());
1742 } 1751 }
1743 1752
1744 1753
1745 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) { 1754 RUNTIME_FUNCTION(Runtime_DebugBreakInOptimizedCode) {
1746 UNIMPLEMENTED(); 1755 UNIMPLEMENTED();
1747 return NULL; 1756 return NULL;
1748 } 1757 }
1749 } // namespace internal 1758 } // namespace internal
1750 } // namespace v8 1759 } // namespace v8
OLDNEW
« no previous file with comments | « src/runtime/runtime.h ('k') | src/runtime/runtime-generator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698