Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(342)

Side by Side Diff: src/interpreter/interpreter-assembler.cc

Issue 2067503002: [debugger] fix stepping over await calls for ignition generators. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@test
Patch Set: address comments Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/interpreter/interpreter-assembler.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/interpreter/interpreter-assembler.h" 5 #include "src/interpreter/interpreter-assembler.h"
6 6
7 #include <limits> 7 #include <limits>
8 #include <ostream> 8 #include <ostream>
9 9
10 #include "src/code-factory.h" 10 #include "src/code-factory.h"
(...skipping 602 matching lines...) Expand 10 before | Expand all | Expand 10 after
613 } 613 }
614 614
615 Node* InterpreterAssembler::StackCheckTriggeredInterrupt() { 615 Node* InterpreterAssembler::StackCheckTriggeredInterrupt() {
616 Node* sp = LoadStackPointer(); 616 Node* sp = LoadStackPointer();
617 Node* stack_limit = Load( 617 Node* stack_limit = Load(
618 MachineType::Pointer(), 618 MachineType::Pointer(),
619 ExternalConstant(ExternalReference::address_of_stack_limit(isolate()))); 619 ExternalConstant(ExternalReference::address_of_stack_limit(isolate())));
620 return UintPtrLessThan(sp, stack_limit); 620 return UintPtrLessThan(sp, stack_limit);
621 } 621 }
622 622
623 Node* InterpreterAssembler::DebugSteppingAcrossAwait() {
rmcilroy 2016/06/14 10:00:22 This is no longer a generic operation that might b
Yang 2016/06/14 11:19:44 Done.
624 Node* step_action =
625 Load(MachineType::Int8(),
626 ExternalConstant(
627 ExternalReference::debug_last_step_action_address(isolate())));
628 STATIC_ASSERT(StepIn > StepNext);
629 STATIC_ASSERT(StepFrame > StepNext);
rmcilroy 2016/06/14 10:00:22 Could you assert that StepFrame is the last elemen
Yang 2016/06/14 11:19:44 Done.
630 Node* step_next = Int32Constant(StepNext);
631 return Int32LessThanOrEqual(step_next, step_action);
632 }
633
623 void InterpreterAssembler::Abort(BailoutReason bailout_reason) { 634 void InterpreterAssembler::Abort(BailoutReason bailout_reason) {
624 disable_stack_check_across_call_ = true; 635 disable_stack_check_across_call_ = true;
625 Node* abort_id = SmiTag(Int32Constant(bailout_reason)); 636 Node* abort_id = SmiTag(Int32Constant(bailout_reason));
626 CallRuntime(Runtime::kAbort, GetContext(), abort_id); 637 CallRuntime(Runtime::kAbort, GetContext(), abort_id);
627 disable_stack_check_across_call_ = false; 638 disable_stack_check_across_call_ = false;
628 } 639 }
629 640
630 void InterpreterAssembler::AbortIfWordNotEqual(Node* lhs, Node* rhs, 641 void InterpreterAssembler::AbortIfWordNotEqual(Node* lhs, Node* rhs,
631 BailoutReason bailout_reason) { 642 BailoutReason bailout_reason) {
632 Label ok(this), abort(this, Label::kDeferred); 643 Label ok(this), abort(this, Label::kDeferred);
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
761 Goto(&loop); 772 Goto(&loop);
762 } 773 }
763 Bind(&done_loop); 774 Bind(&done_loop);
764 775
765 return array; 776 return array;
766 } 777 }
767 778
768 } // namespace interpreter 779 } // namespace interpreter
769 } // namespace internal 780 } // namespace internal
770 } // namespace v8 781 } // namespace v8
OLDNEW
« no previous file with comments | « src/interpreter/interpreter-assembler.h ('k') | src/runtime/runtime.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698