content/browser/renderer_host/render_view_host_impl.h - Issue 2067493003: Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_impl.h

Issue 2067493003: Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@grant-file-access-after-transfer

Patch Set: Pulling in some changes that got removed from the dependent CL. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/child_process_security_policy_impl.cc ('K') | « content/browser/frame_host/render_frame_host_impl.cc ('k') | content/browser/renderer_host/render_view_host_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_impl.h

diff --git a/content/browser/renderer_host/render_view_host_impl.h b/content/browser/renderer_host/render_view_host_impl.h

index 495ee210b3b32f6fe8ffe29fed59ae974c5d0089..42a811ae0ae24002304621b381e1ad476297a0f8 100644

--- a/content/browser/renderer_host/render_view_host_impl.h

+++ b/content/browser/renderer_host/render_view_host_impl.h

@@ -337,16 +337,6 @@ class CONTENT_EXPORT RenderViewHostImpl : public RenderViewHost,

// See https://crbug.com/304341.

WebPreferences ComputeWebkitPrefs();

- // Returns whether the current RenderProcessHost has read access to the files

- // reported in |state|.

- bool CanAccessFilesOfPageState(const PageState& state) const;

- // Grants the current RenderProcessHost read access to any file listed in

- // |validated_state|. It is important that the PageState has been validated

- // upon receipt from the renderer process to prevent it from forging access to

- // files without the user's consent.

- void GrantFileAccessFromPageState(const PageState& validated_state);

// 1. Grants permissions to URL (if any)

// 2. Grants permissions to filenames

// 3. Grants permissions to file system files.