Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Moving CanAccessFilesOfPageState and CanAccessFilesOfPageState methods
from RenderViewHostImpl into RenderFrameHostImpl (and refactoring
and deduplicating some code along the way).

BUG=613260
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/43c38f1248a0e5f70c025675cd0de7c2f4628f0d
Cr-Commit-Position: refs/heads/master@{#400479}

[Łukasz Anforowicz, 2016-06-13 22:17:11]

Description was changed from

==========
Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Moving CanAccessFilesOfPageState and CanAccessFilesOfPageState methods
from RenderViewHostImpl into RenderFrameHostImpl (and refactoring
and deduplicating some code along the way).

BUG=613260
==========

to

==========
Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Moving CanAccessFilesOfPageState and CanAccessFilesOfPageState methods
from RenderViewHostImpl into RenderFrameHostImpl (and refactoring
and deduplicating some code along the way).

BUG=613260
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

[Łukasz Anforowicz, 2016-06-14 20:02:03]

lukasza@chromium.org changed reviewers:
+ creis@chromium.org

[Łukasz Anforowicz, 2016-06-14 20:02:03]

Charlie, can you take a look please?

[Charlie Reis, 2016-06-16 22:06:50]

LGTM!

[Charlie Reis, 2016-06-17 07:07:39]

Still LGTM.

https://codereview.chromium.org/2067493003/diff/110001/content/browser/child_...
File content/browser/child_process_security_policy_impl.cc (right):

https://codereview.chromium.org/2067493003/diff/110001/content/browser/child_...
content/browser/child_process_security_policy_impl.cc:370: bool
ChildProcessSecurityPolicyImpl::CanReadAllFiles(
Nit: This is in the wrong section of the file.  The first half of this file is
all AutoLock methods called by the methods in the second half.  Can you move it
down closer to CanReadFile below?

[Łukasz Anforowicz, 2016-06-17 16:21:09]

https://codereview.chromium.org/2067493003/diff/110001/content/browser/child_...
File content/browser/child_process_security_policy_impl.cc (right):

https://codereview.chromium.org/2067493003/diff/110001/content/browser/child_...
content/browser/child_process_security_policy_impl.cc:370: bool
ChildProcessSecurityPolicyImpl::CanReadAllFiles(
On 2016/06/17 07:07:39, Charlie Reis (OOO til June 18) wrote:
> Nit: This is in the wrong section of the file.  The first half of this file is
> all AutoLock methods called by the methods in the second half.  Can you move
it
> down closer to CanReadFile below?

Done.

[Łukasz Anforowicz, 2016-06-17 17:19:01]

The CQ bit was checked by lukasza@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-17 17:19:31]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067493003/150001

[commit-bot: I haz the power, 2016-06-17 18:41:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-17 18:41:30]

Dry run: This issue passed the CQ dry run.

[Łukasz Anforowicz, 2016-06-17 20:02:23]

The CQ bit was checked by lukasza@chromium.org

[Łukasz Anforowicz, 2016-06-17 20:02:23]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2067493003/#ps150001
(title: "Rebasing...")

[commit-bot: I haz the power, 2016-06-17 20:02:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2067493003/150001

[commit-bot: I haz the power, 2016-06-17 20:07:57]

Committed patchset #9 (id:150001)

[commit-bot: I haz the power, 2016-06-17 20:10:07]

Description was changed from

==========
Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Moving CanAccessFilesOfPageState and CanAccessFilesOfPageState methods
from RenderViewHostImpl into RenderFrameHostImpl (and refactoring
and deduplicating some code along the way).

BUG=613260
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Moving (Can|Grant)AccessFilesOfPageState into RenderFrameHostImpl.

Moving CanAccessFilesOfPageState and CanAccessFilesOfPageState methods
from RenderViewHostImpl into RenderFrameHostImpl (and refactoring
and deduplicating some code along the way).

BUG=613260
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_site_isolation

Committed: https://crrev.com/43c38f1248a0e5f70c025675cd0de7c2f4628f0d
Cr-Commit-Position: refs/heads/master@{#400479}
==========

[commit-bot: I haz the power, 2016-06-17 20:10:08]

Patchset 9 (id:??) landed as
https://crrev.com/43c38f1248a0e5f70c025675cd0de7c2f4628f0d
Cr-Commit-Position: refs/heads/master@{#400479}