Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 2067473003: SkMultiPictureDocument: don't rely on SkPicture::cullRect (Closed)

Created:
4 years, 6 months ago by hal.canary
Modified:
4 years, 6 months ago
Reviewers:
tomhudson
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

SkMultiPictureDocument: don't rely on SkPicture::cullRect SkPicture::cullRect() is not guaranteed to be the same as the bounds passed to SkPictureRecorder::beginRecording(). Committed: https://skia.googlesource.com/skia/+/59d6402ba7dae4ed1e26c155b7c446d6f7ec3527

Patch Set 1 #

Total comments: 2

Patch Set 2 : 2016-06-14 (Tuesday) 13:51:32 EDT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -12 lines) Patch
M src/utils/SkMultiPictureDocument.cpp View 1 3 chunks +28 lines, -12 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
hal.canary
PTAL
4 years, 6 months ago (2016-06-13 18:01:45 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067473003/1
4 years, 6 months ago (2016-06-13 18:39:32 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-13 19:03:03 UTC) #7
tomhudson
WHY NOT? (rely on SkPicture::cullRect)
4 years, 6 months ago (2016-06-14 15:56:17 UTC) #8
hal.canary
On 2016/06/14 15:56:17, tomhudson wrote: > WHY NOT? > > (rely on SkPicture::cullRect) According to ...
4 years, 6 months ago (2016-06-14 15:58:16 UTC) #9
tomhudson
LGTM https://codereview.chromium.org/2067473003/diff/1/src/utils/SkMultiPictureDocument.cpp File src/utils/SkMultiPictureDocument.cpp (right): https://codereview.chromium.org/2067473003/diff/1/src/utils/SkMultiPictureDocument.cpp#newcode77 src/utils/SkMultiPictureDocument.cpp:77: SkSize fPageSize; bikeshed: fCurrentPageSize?
4 years, 6 months ago (2016-06-14 17:23:29 UTC) #10
hal.canary
https://codereview.chromium.org/2067473003/diff/1/src/utils/SkMultiPictureDocument.cpp File src/utils/SkMultiPictureDocument.cpp (right): https://codereview.chromium.org/2067473003/diff/1/src/utils/SkMultiPictureDocument.cpp#newcode77 src/utils/SkMultiPictureDocument.cpp:77: SkSize fPageSize; On 2016/06/14 17:23:29, tomhudson wrote: > bikeshed: ...
4 years, 6 months ago (2016-06-14 17:53:28 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067473003/20001
4 years, 6 months ago (2016-06-14 17:53:37 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 18:06:41 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/59d6402ba7dae4ed1e26c155b7c446d6f7ec3527

Powered by Google App Engine
This is Rietveld 408576698