Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(363)

Issue 2067443004: Fix struct alignment for SIMD objects. (Closed)

Created:
4 years, 6 months ago by Florian Schneider
Modified:
4 years, 6 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix struct alignment for SIMD objects. This is caused by differnet packing of structs in the host- and target-toolchain - in this case the Android XARM compiler does align the SIMD payload differently than the SIMARM host. (also see a similar bug fix for doubles/mints: 5dc51af924b9d3cb1005a530fe95dc1663b1eb53) BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/fb75e1e5e481334260b2fd467393a367fc74389a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M runtime/vm/raw_object.h View 3 chunks +6 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Florian Schneider
4 years, 6 months ago (2016-06-13 22:35:21 UTC) #3
rmacnak
lgtm
4 years, 6 months ago (2016-06-13 23:02:00 UTC) #4
Florian Schneider
4 years, 6 months ago (2016-06-13 23:06:09 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fb75e1e5e481334260b2fd467393a367fc74389a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698