Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(801)

Issue 2067433003: [wasm] MemSize, BoundsCheck should use Relocatable constants (Closed)

Created:
4 years, 6 months ago by gdeepti
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] MemSize, BoundsCheck should use Relocatable constants MemSize should use Relocatable constants, remove unconditional throw on no linear memory as this should be patched on GrowMemory. R=mtrofin@chromium.org, bradnelson@chromium.org Committed: https://crrev.com/ea8f887f320cb59d032bfd77f02f08f626e03bad Cr-Commit-Position: refs/heads/master@{#36943}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -13 lines) Patch
M src/compiler/wasm-compiler.cc View 1 2 chunks +15 lines, -13 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
gdeepti
4 years, 6 months ago (2016-06-13 19:52:47 UTC) #1
bradnelson
lgtm
4 years, 6 months ago (2016-06-13 20:16:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067433003/20001
4 years, 6 months ago (2016-06-13 20:37:57 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/17115)
4 years, 6 months ago (2016-06-13 20:41:44 UTC) #6
Mircea Trofin
On 2016/06/13 20:41:44, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-13 20:59:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2067433003/20001
4 years, 6 months ago (2016-06-13 21:01:13 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 21:03:54 UTC) #10
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:08:15 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ea8f887f320cb59d032bfd77f02f08f626e03bad
Cr-Commit-Position: refs/heads/master@{#36943}

Powered by Google App Engine
This is Rietveld 408576698