src/IceCompileServer.cpp - Issue 2067403002: Instrumented load and store with dummy calls to __asan_check().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceCompileServer.cpp

Issue 2067403002: Instrumented load and store with dummy calls to __asan_check(). (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Improved tests Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceCompileServer.cpp

diff --git a/src/IceCompileServer.cpp b/src/IceCompileServer.cpp

index b1f168c8a97b9b777174a1889aea36ebd2c577c6..5ace25c3fba8a7e1bbd89359033a0f3cb2661bb8 100644

--- a/src/IceCompileServer.cpp

+++ b/src/IceCompileServer.cpp

@@ -243,7 +243,6 @@ void CLCompileServer::run() {

Ctx.reset(new GlobalContext(Ls.get(), Os.get(), Ls.get(), ELFStr.get()));

- // TODO(tlively): Make this instantiate an instrumentation subclass

if (!BuildDefs::minimal() && getFlags().getSanitizeAddresses()) {

std::unique_ptr<Instrumentation> Instr(new ASanInstrumentation(Ctx.get()));

Ctx->setInstrumentation(std::move(Instr));

« no previous file with comments | « src/IceASanInstrumentation.cpp ('k') | tests_lit/asan_tests/instrumentload.ll » ('j') | no next file with comments »