Instrumented load and store with dummy calls to __asan_check().

Instrumented load and store with dummy calls to __asan_check().

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=bdb912f4fccc8f8710d219277fee342a897427c8

[tlively, 2016-06-15 23:08:40]

tlively@google.com changed reviewers:
+ kschimpf@google.com, mcgrathr@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2016-06-16 03:58:51]

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
File tests_lit/asan_tests/instrumentload.ll (right):

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentload.ll:1: ; Test for a call to __asan_check()
preceeding loads
preceding

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentload.ll:69: ; DUMP-LABEL: define internal void
@doLoads() { # doLoads(i=36:b=1)
I would omit the "#" and everything after it from the check line, because that
portion of the dump output is not guaranteed to be stable.

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
File tests_lit/asan_tests/instrumentstore.ll (right):

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentstore.ll:1: ; Test for a call to __asan_check()
preceeding stores
preceding

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentstore.ll:50: ; DUMP-LABEL: define internal void
@doStores(<4 x i32> %vecSrc) { # doStores(i=26:b=1)
Same comment about "#" and everything after it on that line.

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentstore.ll:66: ; DUMP-NEXT: store <4 x i32>
%vecSrc, <4 x i32>* @destGlobal128, align 4, beacon %vecSrc
I would also omit ", beacon ..." even though it's part of the dump output,
because nothing like that is in the original bitcode.

[tlively, 2016-06-16 17:35:55]

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
File tests_lit/asan_tests/instrumentload.ll (right):

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentload.ll:1: ; Test for a call to __asan_check()
preceeding loads
On 2016/06/16 03:58:51, stichnot wrote:
> preceding

Done.

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentload.ll:69: ; DUMP-LABEL: define internal void
@doLoads() { # doLoads(i=36:b=1)
On 2016/06/16 03:58:51, stichnot wrote:
> I would omit the "#" and everything after it from the check line, because that
> portion of the dump output is not guaranteed to be stable.

Since DUMP-LABEL matches the entire line, I had to add the dump section header
to make the test work. I am applying this pattern to the other tests as well.

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
File tests_lit/asan_tests/instrumentstore.ll (right):

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentstore.ll:1: ; Test for a call to __asan_check()
preceeding stores
On 2016/06/16 03:58:51, stichnot wrote:
> preceding

Done.

https://codereview.chromium.org/2067403002/diff/20001/tests_lit/asan_tests/in...
tests_lit/asan_tests/instrumentstore.ll:66: ; DUMP-NEXT: store <4 x i32>
%vecSrc, <4 x i32>* @destGlobal128, align 4, beacon %vecSrc
On 2016/06/16 03:58:51, stichnot wrote:
> I would also omit ", beacon ..." even though it's part of the dump output,
> because nothing like that is in the original bitcode.

Done.

[Karl, 2016-06-16 17:38:14]

lgtm

[tlively, 2016-06-16 18:03:18]

Description was changed from

==========
Instrumented load and store with dummy calls to __asan_check().

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
==========

to

==========
Instrumented load and store with dummy calls to __asan_check().

BUG=https://bugs.chromium.org/p/nativeclient/issues/detail?id=4374
R=kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[tlively, 2016-06-16 18:03:20]

Committed patchset #3 (id:40001) manually as
bdb912f4fccc8f8710d219277fee342a897427c8 (presubmit successful).