appengine/findit/crash/results.py - Issue 2067373002: [Findit] Add fracas analysis result feedback page for manual triage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/crash/results.py

Issue 2067373002: [Findit] Add fracas analysis result feedback page for manual triage. (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@only-dashboard

Patch Set: Fix bugs. Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: appengine/findit/crash/results.py

diff --git a/appengine/findit/crash/results.py b/appengine/findit/crash/results.py

index cb24f1968cc60fa5cfc0927106dd7f4951fdc6e0..69db1f03d96859e37459255252575aa7a38467fc 100644

--- a/appengine/findit/crash/results.py

+++ b/appengine/findit/crash/results.py

@@ -37,7 +37,7 @@ class Result(object):

for file_path, stack_infos in self.file_to_stack_infos.iteritems():

line_parts = []

for frame, _ in stack_infos:

- line_parts.append('%s (#%d)' % (frame.function, frame.index))

+ line_parts.append('frame #%d' % frame.index)

stgao 2016/06/16 17:32:04 Could we avoid including the change from the other

Sharu Jiang 2016/06/21 20:28:49 Yes, I uploaded separate cl for this, after rebase

lines.append('Changed file %s crashed in %s' % (

file_path, ', '.join(line_parts)))

« no previous file with comments | « no previous file | appengine/findit/crash/scorers/test/aggregator_test.py » ('j') | appengine/findit/handlers/crash/fracas_result_feedback.py » ('J')